Last modified: 2011-10-28 20:09:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33403, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31403 - Autoblocks popping up for long-since blocked users frequently
Autoblocks popping up for long-since blocked users frequently
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.18.x
All All
: High normal (vote)
: ---
Assigned To: Aaron Schulz
: need-integration-test, platformeng
Depends on: 27858
Blocks: 29876
  Show dependency treegraph
 
Reported: 2011-10-06 02:24 UTC by Mark A. Hershberger
Modified: 2011-10-28 20:09 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark A. Hershberger 2011-10-06 02:24:58 UTC
From [[WP:VPT]]:

We're seeing autoblocks pop up in cases where the blocked user hasn't edited in a Very Long Time. For instance, at [[User talk:Esoglou]], we see he was hit by an autoblock from an account blocked in late 2009. I've seen several other such today.

and

http://en.wikipedia.org/wiki/Special:BlockList?wpTarget=%233617969 should show (in this case) the autoblock information; I don't see any way to lift an autoblock any more.
Comment 1 Aaron Schulz 2011-10-06 03:33:45 UTC
BlockList fix made in r99076.

In any case, on my testwiki, clicking the "change block" link lets me undo autoblocks without problems.
Comment 2 Tim Starling 2011-10-06 05:14:44 UTC
Autoblocks are created when User::getBlockedStatus() is called. It's possible that in 1.17, this function was only called when the user attempted to edit, whereas in 1.18, it is called more often, perhaps when the user logs in via CentralAuth to another wiki. If this is the case, then it is a performance regression as well as a nuisance.

I investigated block #3618416. The user in question is permanently blocked on en.wikipedia.org, but was editing meta.wikimedia.org at approximately the time of the autoblock.
Comment 3 Mark A. Hershberger 2011-10-06 15:33:43 UTC
More: 	
14:39, 6 October 2011 Autoblock #3620311 14:39, 7 October 2011 (unblock) Jpgordon (talk | contribs | block) account creation blocked (Autoblocked because your IP address was recently used by "Jpotts15". The reason given for Jpotts15's block is: "Vandalism-only account".) 

Here's another: http://en.wikipedia.org/w/index.php?title=Special:BlockList&action=search&ip=%233619641 -- this time the block was in 2010.
Comment 4 Josh Gordon 2011-10-06 18:18:06 UTC
More verification of global cause: an unblock request on enwiki related to

http://pt.wikipedia.org/w/index.php?title=Special:Contributions/Ingrid%20Rodrigues

She's blocked on enwiki since 11 May 2010.
Comment 5 Max Semenik 2011-10-07 13:58:53 UTC
Backtrace on usual page view of a special page:
 #1 D:\Projects\MediaWiki\includes\User.php(1550): User->getBlockedStatus(true)
 #2 D:\Projects\MediaWiki\includes\User.php(1540): User->getBlock(true)
 #3 D:\Projects\MediaWiki\includes\Skin.php(639): User->isBlocked()
 #4 D:\Projects\MediaWiki\includes\SkinTemplate.php(247): Skin->getUndeleteLink()
 #5 D:\Projects\MediaWiki\includes\OutputPage.php(1876): SkinTemplate->outputPage()
 #6 D:\Projects\MediaWiki\includes\Wiki.php(381): OutputPage->output()
 #7 D:\Projects\MediaWiki\includes\Wiki.php(624): MediaWiki->finalCleanup()
 #8 D:\Projects\MediaWiki\includes\Wiki.php(532): MediaWiki->main()
 #9 D:\Projects\MediaWiki\index.php(58): MediaWiki->run()
 #10 {main}

This whole bloody system of implicit autoblocks needs a rewrite.

Caused by r93246, reverted in r93246.
Comment 6 Max Semenik 2011-10-07 14:03:04 UTC
Grrr, reverted in r99211.
Comment 7 Aaron Schulz 2011-10-07 19:55:14 UTC
(In reply to comment #6)
> Grrr, reverted in r99211.

That reverted code that was not deployed. The reverted code would have made this worse if it was deployed, though.
Comment 8 Aaron Schulz 2011-10-08 20:24:50 UTC
Possible fix in r99323 to reduce occurrence of this.
Comment 9 Mark A. Hershberger 2011-10-09 03:30:20 UTC
since this hasn't been deployed yet, here is another (similar) report: http://en.wikipedia.org/w/index.php?diff=454639680
Comment 10 Aaron Schulz 2011-10-09 03:38:00 UTC
(In reply to comment #9)
> since this hasn't been deployed yet, here is another (similar) report:
> http://en.wikipedia.org/w/index.php?diff=454639680

I don't see the relation? Wrong link?
Comment 11 AlexSm 2011-10-09 04:42:00 UTC
Correct link to report: 
http://en.wikipedia.org/w/index.php?diff=454640449

Comment: it would be nice to at least have a "hint" that IP is rangeblocked like it was before (I understand for autoblocks it was a privacy issue)
see http://en.wikipedia.org/w/index.php?diff=454656826
Comment 12 Ronhjones 2011-10-11 19:03:06 UTC
This user 
http://en.wikipedia.org/wiki/User_talk:Manny_may
has had 3 autoblocks in a week - all repeating an autoblock 11 months ago.
Comment 13 Rob Lanphier 2011-10-11 21:04:49 UTC
Assigning to Tim for review of r99323 and followups.  Can assign back to Aaron for backporting and deployment
Comment 14 Mark A. Hershberger 2011-10-15 22:03:08 UTC
tagging bugs for Marcus to look at
Comment 15 Risker 2011-10-16 12:47:59 UTC
(In reply to comment #12)
> This user 
> http://en.wikipedia.org/wiki/User_talk:Manny_may
> has had 3 autoblocks in a week - all repeating an autoblock 11 months ago.

For the record, this new account was at times editing on the same IP address as the original, indefinitely blocked account - and turns out to be a sock of the original account.  

While I realise that you're trying to resolve all bugs, and this may only be one aspect of a larger issue to be fixed...as an early warning system of a returned indef blocked user, this particular bug characteristic is not a net negative.
Comment 16 Tim Starling 2011-10-21 04:22:24 UTC
Reviewed and tagged for backport.
Comment 17 Rob Lanphier 2011-10-21 18:07:12 UTC
Assigning to Aaron to finish off and deploy.
Comment 18 Mark A. Hershberger 2011-10-24 16:53:09 UTC
Maybe related to Bug 31893 ??
Comment 19 Aaron Schulz 2011-10-24 23:19:58 UTC
Backported and live.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links