Last modified: 2012-06-21 17:28:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33398, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31398 - Revision information not rendered in edit notices
Revision information not rendered in edit notices
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-integration-test
Depends on:
Blocks: 29876
  Show dependency treegraph
 
Reported: 2011-10-05 22:59 UTC by Robert Rohde
Modified: 2012-06-21 17:28 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robert Rohde 2011-10-05 22:59:13 UTC
Since the update, magic words such as {{REVISIONID}} and {{REVISIONUSER}} result in blank strings when they appear in an edit notice.  Presumably these ought to report the values for the last saved revision of the page one is about to edit.

Example:

http://en.wikipedia.org/w/index.php?title=User:Dragons_flight/editnotice_test&action=edit

Compared to:

http://en.wikipedia.org/wiki/Template:Editnotices/Page/User:Dragons_flight/editnotice_test

I've included a number of other magic words to show that most of these still render correctly.
Comment 1 Gadget850 2011-10-06 01:41:53 UTC
This use was always considered incorrect and was fixed per bug 19006.
Comment 2 Robert Rohde 2011-10-06 02:28:58 UTC
No, the prior behavior was to show the name of the current user loading the page.  However, the current behavior is to show nothing.  If the point of the revision functions is to show information about the last saved revision, then neither behavior is correct.

I'm not looking for a {{CURRENTUSER}}.  I'm just looking for revision magic words that actually report information about the saved revision.
Comment 3 Gadget850 2011-10-06 02:47:06 UTC
You are right- it should not show nothing.
Comment 4 Daniel Friesen 2011-10-06 17:51:50 UTC
Note that the behaviour of {{REVISIONID}} and {{REVISIONUSER}} in an edit page
preview IS to return blank. It seams the behaviour has just changed to use the
behaviour of an edit page preview (since you are on the edit page) rather than
the latest revision of the page or some custom behaviour.
Comment 5 Mark A. Hershberger 2011-10-06 20:36:55 UTC
https://secure.wikimedia.org/wikipedia/en/w/index.php?&diff=prev&oldid=454282519

This has also broken all the policy and guideline editnotices, which use {{tl|policy-guideline-editnotice}}, which uses {{tlc|REVISIONUSER}}
Comment 6 Mark A. Hershberger 2011-10-15 19:11:16 UTC
We very sorry this could included in 1.18, but this we decided to take care of the long-open bug to remove this feature.
Comment 7 Mark A. Hershberger 2011-10-15 22:03:44 UTC
tagging bugs for Marcus to look at

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links