Last modified: 2011-10-15 22:03:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33395, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31395 - Regression: <includeonly>subst:</includeonly> is not parsed when viewing in an edit notice
Regression: <includeonly>subst:</includeonly> is not parsed when viewing in a...
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.18.x
All All
: Highest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-integration-test
Depends on:
Blocks: 29876
  Show dependency treegraph
 
Reported: 2011-10-05 21:54 UTC by Carl Fürstenberg
Modified: 2011-10-15 22:03 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Carl Fürstenberg 2011-10-05 21:54:42 UTC
Trying for example create an new Featured picture candidate on commons, the edit intro usually shows what code should be entered on the list page, for example Trying to create an nomination of image called 'Testing.jpg' you'll be redirected to edit page:

http://commons.wikimedia.org/w/index.php?action=edit&preload=Template%3AFPCnomNewerPreload&editintro=Template%3AFPCnomNewInstructions&summary=&nosummary=&prefix=&minor=&title=Commons%3AFeatured+picture+candidates%2FFile%3ATesting.jpg&create=Create+new+nomination

The edit intro now says '{{{{subst:FULLPAGENAME}}}}', last week it would say '{{Commons:Featured picture candidates/File:Testing.jpg}}' instead.
Comment 1 Robert Rohde 2011-10-05 22:25:35 UTC
I've noticed that the magic word {{REVISIONUSER}} renders as a blank string when placed in an edit notice.  This sounds suspiciously like the same bug.
Comment 2 Krinkle 2011-10-05 22:37:34 UTC
(In reply to comment #0)
> The edit intro now says '{{{{subst:FULLPAGENAME}}}}', last week it would say
> '{{Commons:Featured picture candidates/File:Testing.jpg}}' instead.

I saw that it was indeed litterally saying "subst:FULLPAGENAME" instead of the actual page name. However, to my knowledge, it was never supposed to show the full page name there. If under 1.17 edit notice showed the full pagename there, then that was a bug. Because in templates and all other transclusions, subst: is only parsed when saved, not via <includeonly>.

The behavior were trying to simulate has been implemented a few years ago as "safesubst:".

However, when looking at Template:FPCnomNewInstructions again, I don't see why you need any of the complicated <includeonly> and subst: for FULLPAGENAME. It can simply just be {{FULLPAGENAME}}.

Edited: http://commons.wikimedia.org/w/index.php?title=Template:FPCnomNewInstructions&diff=prev&oldid=60608306

Marking INVALID as this was a fixed bug in inconsistency between the editnotice parser and the regular parser, not a regression.


(In reply to comment #1)
> I've noticed that the magic word {{REVISIONUSER}} renders as a blank string
> when placed in an edit notice.  This sounds suspiciously like the same bug.

These are not related as far as I know. Please open a new bug for that including steps to reproduce or a live example.

Thanks :)
Comment 3 Mark A. Hershberger 2011-10-15 22:03:22 UTC
tagging bugs for Marcus to look at

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links