Last modified: 2011-10-15 19:01:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33391, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31391 - Aspect ratio incorrect for rotated images uploaded prior to 1.18 deployment
Aspect ratio incorrect for rotated images uploaded prior to 1.18 deployment
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.18.x
All All
: Normal major (vote)
: ---
Assigned To: Sam Reed (reedy)
:
Depends on: 30961
Blocks: 31504 29876
  Show dependency treegraph
 
Reported: 2011-10-05 19:06 UTC by Maarten Dammers
Modified: 2011-10-15 19:01 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maarten Dammers 2011-10-05 19:06:59 UTC
See for example http://commons.wikimedia.org/wiki/File:Vestergrave_48_%282%29.jpg . The image is rotated but it looks like the image still has the same length and width (length and with should be switched).
Comment 1 Brion Vibber 2011-10-05 19:08:29 UTC
Looks a-ok to me...

Full resolution‎ (3,456 × 5,184 pixels, file size: 5.28 MB, MIME type: image/jpeg) 

3,456×5,184 (5.28 MB)
Comment 2 Maarten Dammers 2011-10-05 19:11:02 UTC
Someone just purged the page so that fixed this one.
Comment 3 Bryan Tong Minh 2011-10-05 19:11:59 UTC
Works for me as well.

Could be that somebody purged the image. Perhaps we should find all pre-1.18 images that have exif rotation set, and purge them?
Comment 4 Saibo 2011-10-05 19:15:05 UTC
Yes, I did purge it. Apparently the dimensions didn't get updated. Therefore the wrong aspect ratio.
Comment 5 Brion Vibber 2011-10-05 19:27:45 UTC
Yes, if they were uploaded prior to the 1.18 upgrade they'll need to be purged.
Comment 6 Bawolff (Brian Wolff) 2011-10-05 19:55:19 UTC
>Could be that somebody purged the image. Perhaps we should find all pre-1.18
>images that have exif rotation set, and purge them?

It's probably not all that easy to find all such images as it stands. We could do the query

select img_name from image where img_minor_mime = 'jpeg' and img_major_mime = 'image' and (img_metadata like '%s:11:"Orientation";i:8%' or img_metadata like '%s:11:"Orientation";i:3%' or img_metadata like '%s:11:"Orientation";i:6%');

But that query would take a fairly long time...
Comment 7 Bryan Tong Minh 2011-10-05 20:09:55 UTC
Somebody can generate the list offline using the sql dumps if that takes too long.
Comment 8 Rob Lanphier 2011-10-05 21:24:19 UTC
Maybe running refreshImageMetadata.php will fix this (see bug 30961).  I have no idea if that's going to be practical with the size of commons, though.
Comment 9 Bawolff (Brian Wolff) 2011-10-06 14:13:23 UTC
(In reply to comment #8)
> Maybe running refreshImageMetadata.php will fix this (see bug 30961).  I have
> no idea if that's going to be practical with the size of commons, though.

That won't affect this. The issue has to do with having cached thumbnails with different dimensions then what a new thumbnail would be, where refreshImageMetadata will just update the img_metadata blob (which would already have orientation in it for this issue to be present).


(In reply to comment #2)
> Someone just purged the page so that fixed this one.

I just viewed it, and it was broken again (by broken again, i mean MediaWiki tried to show me the 800px wide version instead of the 400px wide version like it should have for a rotated image), purging re-fixed, but the fact it reverted to thinking the orientation was normal might be some sort of other bug.
Comment 10 Bryan Tong Minh 2011-10-06 19:31:22 UTC
(In reply to comment #9)
> (In reply to comment #2)
> > Someone just purged the page so that fixed this one.
> 
> I just viewed it, and it was broken again (by broken again, i mean MediaWiki
> tried to show me the 800px wide version instead of the 400px wide version like
> it should have for a rotated image), purging re-fixed, but the fact it reverted
> to thinking the orientation was normal might be some sort of other bug.

Perhaps if somebody purges it on a 1.17 wiki?
Comment 11 Mark A. Hershberger 2011-10-15 19:01:35 UTC
If you see this bug and ?action=purge doesn't fix it and re-uploading doesn't fix it, then open a bug for that image.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links