Last modified: 2014-11-17 09:21:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33362, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31362 - Lost CSS styles in pages transcluding pages from the Special: namespace
Lost CSS styles in pages transcluding pages from the Special: namespace
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.18.x
All All
: High major with 2 votes (vote)
: 1.18.0 release
Assigned To: Nobody - You can work on this!
: need-integration-test
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-05 01:19 UTC by vlakoff
Modified: 2014-11-17 09:21 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description vlakoff 2011-10-05 01:19:10 UTC
Hello,

Here is an issue related to the recent 1.18 deployment. Some pages do include {{Special:Prefixindex/something}}. They were usually relying on the CSS property "width:98%" of #mw-prefixindex-list-table, among others properties I guess, but now this property is loaded from another file, specific to the Special: pages, i.e. http://bits.wikimedia.org/fr.wikipedia.org/load.php?debug=true&lang=fr&modules=mediawiki.special&only=styles&skin=vector

So, the pages that are including a page from the Special: namespace lost these CSS styles.

For example, compare http://fr.wikipedia.org/wiki/Sp%C3%A9cial:Index/Utilisateur:Od1n/ with http://fr.wikipedia.org/wiki/Utilisateur:Od1n/Sous-pages ; before, the latter had a 98 % width as the former.

So basically, the styling system is now written to only include the styling for Special pages on special pages, incorrectly assuming that Special pages are not transcludeable.
Comment 2 Krinkle 2011-10-05 21:58:49 UTC
Not sure what the 'proper' solution is, but I think either the parser needs to detect the modules added by the special page being transcluded and copy those to it's own modules queue, or the specialpage class for PrefixIndex needs to specifically add the modules when trancluding as well.
Comment 3 Bawolff (Brian Wolff) 2011-10-08 23:34:13 UTC
(In reply to comment #2)
> Not sure what the 'proper' solution is, but I think either the parser needs to
> detect the modules added by the special page being transcluded and copy those
> to it's own modules queue, or the specialpage class for PrefixIndex needs to
> specifically add the modules when trancluding as well.

Well the specialpage class doesn't really have access to the parser object or the OutputPage object when transcluding, so it can't really add them. Merging the modules used in SpecialPageFactory::capturePath is probably the right solution

----

This bug does not appear to be present on trunk. I'm not sure why...
Comment 4 Bawolff (Brian Wolff) 2011-10-08 23:56:44 UTC
>This bug does not appear to be present on trunk. I'm not sure why...

Apparently on trunk it got fixed as part of r93758
Comment 5 Mark A. Hershberger 2011-10-15 18:42:35 UTC
need to verify that this works in 1.17.  If it doesn't then take off the regression bit.
Comment 6 Tim Starling 2011-10-15 18:47:09 UTC
Confirmed that it works in 1.17.
Comment 7 Mark A. Hershberger 2011-10-15 22:03:16 UTC
tagging bugs for Marcus to look at
Comment 8 Mark A. Hershberger 2011-11-02 17:10:39 UTC
(In reply to comment #4)
> >This bug does not appear to be present on trunk. I'm not sure why...
> 
> Apparently on trunk it got fixed as part of r93758

Backported now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links