Last modified: 2011-10-05 19:03:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33354, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31354 - LQT should not give protocol relative URLs when the user click on "Link To"
LQT should not give protocol relative URLs when the user click on "Link To"
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://pt.wikibooks.org/wiki/T%C3%B3...
:
Depends on:
Blocks: 20342
  Show dependency treegraph
 
Reported: 2011-10-04 19:54 UTC by Helder
Modified: 2011-10-05 19:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Links provided by LQT (138.84 KB, image/png)
2011-10-05 12:09 UTC, Helder
Details

Description Helder 2011-10-04 19:54:12 UTC
I noticed the LQT extension is providing links such as
 //pt.wikibooks.org/wiki/...
instead of
 http://pt.wikibooks.org/wiki/...
or
 https://pt.wikibooks.org/wiki/...

I think it should complete/expand the URL by including the protocol before showing it in the dialog for the user.
Comment 1 Roan Kattouw 2011-10-05 10:14:24 UTC
How does this actually break for you? If I click "Copy link location" in Firefox, Firefox expands the URL to https:// for me. Are you using a browser that doesn't have this behavior? Is there any other reason why you don't want it to be protocol-relative?
Comment 2 Helder 2011-10-05 12:09:40 UTC
Created attachment 9161 [details]
Links provided by LQT

The link I was referring to is the one provided in a popup when the user clicks on "Link To", not the text which would be copied by using the right button of the mouse. See the part marked in red on the attached screenshot.

Since bug 24627 was not fixed yet, and the popup still provides two versions of the link instead of only one which could be copied directly, I believe the user is not supposed to be coping the link by right-clicking on the "Link To", but by using the popup which should have the full link.

The current behavior forces the user to do an additional step (of adding the protocol by hand) if he/she wants to copy the link to an e-mail, since protocol relative links doesn't works (I mean, Gmail for example won't make the "//link" string to be converted in a https link: the "//" will be left out of the clickable http "link").
Comment 3 Roan Kattouw 2011-10-05 17:51:55 UTC
Right, I didn't know about the popup.
Comment 4 Roan Kattouw 2011-10-05 19:02:11 UTC
Fixed in r99022 and deployed to 1.18 wikis. Didn't put this in 1.17 because we plan to deploy 1.18 to all wikis in a few hours anyway. ptwikibooks is still on 1.17 so it won't have the fix until it's upgraded. I confirmed the fix at https://www.mediawiki.org/wiki/Project:Current_issues

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links