Last modified: 2012-02-03 13:06:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33294, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31294 - allow protocol-relative URLs in $wgCaptchaWhitelist
allow protocol-relative URLs in $wgCaptchaWhitelist
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ConfirmEdit (CAPTCHA extension) (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks: 20342
  Show dependency treegraph
 
Reported: 2011-10-01 12:25 UTC by Umherirrender
Modified: 2012-02-03 13:06 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2011-10-01 12:25:43 UTC
A IP of de.wiki was telling, that he get a CAPTCHA for a edit, where only a comma is changed[1].

In my opinion is this a problem with protocol-relative URLs.

The page includes a fullurl to commons. Before the edit the database contains a http link to commons, after the reparse due to the edit the link to commons is changed to a protocol-relative URL and ConfirmEdit is seeing a different and trigger the CAPTCHA -> bad in this case.

We can fix this by editing all templates with fullurl to trigger a reparse with the Job Queue, but that sounds like many load for the server and also fixed that problem only on de.wiki.

[1] http://de.wikipedia.org/w/index.php?title=Simone_de_Beauvoir&diff=94101544&oldid=92622886
Comment 1 Juergen 2011-10-01 12:51:25 UTC
Shouldn't we allow external links to commons from IP Users without a captcha, even when they are really new and not caused by protocol-relative URLs as explained by Umherirrender ?

This mechanism seems to be working already in the case of external links to WP (for instance for links like the diff-link from the description).
Comment 2 Umherirrender 2011-10-01 13:03:02 UTC
Links to Commons already allowed, when there are containing http or https at the begin. See $wgCaptchaWhitelist in http://noc.wikimedia.org/conf/CommonSettings.php.txt

$wgCaptchaWhitelist needs changing for protocol-relative URLs
-> Using this as shell bug, changing summary and component.
Comment 3 Roan Kattouw 2011-10-03 12:52:20 UTC
Done:

-       $wgCaptchaWhitelist = '#^https?://([.a-z0-9-]+\\.)?((wikimedia|wikipedia|wiktionary|wikiquote|wikibooks|wikisource|wikispecies|mediawiki|wikimediafoundation|wikinews|wikiversity)\.org|dnsstuff\.com|completewhois\.com|wikimedia\.de|toolserver\.org)(/|$)#i';
+       $wgCaptchaWhitelist = '#^(https?:)?//([.a-z0-9-]+\\.)?((wikimedia|wikipedia|wiktionary|wikiquote|wikibooks|wikisource|wikispecies|mediawiki|wikimediafoundation|wikinews|wikiversity)\.org|dnsstuff\.com|completewhois\.com|wikimedia\.de|toolserver\.org)(/|$)#i';

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links