Last modified: 2011-10-11 08:02:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33196, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31196 - .headerSort should have a padding accounting for the sortable icon to avoid icons through text
.headerSort should have a padding accounting for the sortable icon to avoid i...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 31601
  Show dependency treegraph
 
Reported: 2011-09-27 20:14 UTC by Romaine
Modified: 2011-10-11 08:02 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Romaine 2011-09-27 20:14:36 UTC
After employing 1.18 last night, tables have the icons for sorting the contents running through the text of the header. (nl-wiki)

Greetings - Romaine
Comment 1 Basvb 2011-09-27 20:34:24 UTC
This happens when there is no width given to the columns, then it only takes the width of the text, and doesn't take into account that there should be some space for the sortable icon as well.
Comment 2 Krinkle 2011-09-27 20:37:23 UTC
Both when there is and isn't a width, there is a padding added to the cell to take the icon into account.

The problem is that nl.wiki overrides the CSS and forces a 4px padding.

nl.wiki should probably remove the styling for 'wikitable' because by keeping your own, it will not be updated automatically with the software. If you wish to have a custom styling, then use a custom class name, not the same as core.

From what I can see, the styling on nl.wiki is the same as in core, so it's redundant. You may wanna keep the lines for the old 'prettytable' since those are not in core.
Comment 3 Krinkle 2011-09-27 20:46:34 UTC
for the record, I've done the latter:

http://nl.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=27335430&oldid=27335375
Comment 4 Romaine 2011-09-27 20:54:35 UTC
Prettytable and wikitable are exactly the same on nl-wiki, and that is the way they are supposed to be. The core styling is customized, and that is they way we want to be it.
Comment 5 Derk-Jan Hartman 2011-09-28 15:13:45 UTC
This can be eleviated by deploying r98069
Comment 6 Derk-Jan Hartman 2011-10-02 11:12:23 UTC
Fix improved with r98665
Comment 7 Derk-Jan Hartman 2011-10-06 15:57:05 UTC
Blegh, still not fixed.

We might have to !important the background options and the padding-right. Apparently people reguraly use per headercell style="background:color;" which totally overrides all improvements again.

Alternative ideas ?
Comment 8 Derk-Jan Hartman 2011-10-08 13:00:05 UTC
Added !important to r99307

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links