Last modified: 2011-09-28 19:40:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33180, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31180 - WikiLove should not fail in if wgServer is protocol-relative
WikiLove should not fail in if wgServer is protocol-relative
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiLove (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks: 20342
  Show dependency treegraph
 
Reported: 2011-09-27 01:59 UTC by Ryan Kaldari
Modified: 2011-09-28 19:40 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2011-09-27 01:59:48 UTC
As of this past weekend, WikiLove seems to be broken on en.wiki and commons (probably everywhere). Everything works except the final step - redirecting the page. It just leaves the user on the page with WikiLove still open, even though the API request succeeds and returns the redirect URL.

I haven't had a chance to debug. If anyone else wants to investigate, be my guest!
Comment 1 Ryan Kaldari 2011-09-27 02:01:11 UTC
By the way, there haven't been any significant code changes in WikiLove for 2 months, so I think the problem may have been caused by something else recently deployed.
Comment 2 Erik Moeller 2011-09-27 08:51:24 UTC
Confirmed in Chrome 13. This is pretty ugly as it may cause people to submit repeatedly.
Comment 3 Roan Kattouw 2011-09-27 10:42:48 UTC
Could not reproduce in Firefox 6.0.1 using secure.
Comment 4 Roan Kattouw 2011-09-27 12:02:35 UTC
Fixed in r98216, fix deployed.
Comment 5 howief 2011-09-28 01:05:40 UTC
I'm seeing this in Firefox 6.0.2 as well.  

to reproduce:

* Complete all the fields for the wikilove and click "send wikilove".  

The screen then jumps to the bottom of the target talk page without the Wikilove being sent.  If I scroll back up, I get the Wikilove dialog box.  From here, I can keep re-sending and the same thing happens.
Comment 6 Erik Moeller 2011-09-28 01:06:01 UTC
I am still able to see this issue (or a very similar one) on Commons, in Chrome 13.0.782 on Ubuntu 10.10.

Steps to reproduce:
1) Visit http://commons.wikimedia.org/wiki/User_talk:Eloquence

2) Invoke WikiLove

3) Select baklava and enter test message

4) Press preview

5) Press send

Expected behavior: Message successfully posted & redirects me to section.

Actual behavior: Background remains faded. URL in address bar changes, but page does not reload and WikiLove widget remains visible at the top.

Here's the odd thing: I've not been able to reproduce this if I set &debug=true. But near as I can tell using the Chrome debugging tools, the same code Roan committed for protocol-relative URLs gets executed (just in the minified version). (I've cleared the browser cache as well, and disabled other JS gadgets.)

Now you'll have to excuse me, I've had a little bit too much baklava.
Comment 7 Krinkle 2011-09-28 18:14:55 UTC
(In reply to comment #4)
> Fixed in r98216, fix deployed.

That fixed it for MediaWiki 1.18+, not for 1.17. Fixed in r98340.
Comment 8 Erik Moeller 2011-09-28 19:40:56 UTC
Confirmed fixed -- thanks Timo & Roan.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links