Last modified: 2012-10-25 09:47:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33122, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31122 - rsvg on scaler does not support styling the root element
rsvg on scaler does not support styling the root element
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
SVG rendering (Other open bugs)
unspecified
All All
: High normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/wiki/Fil...
: upstream
: 33323 (view as bug list)
Depends on: 36623
Blocks: svg 34947
  Show dependency treegraph
 
Reported: 2011-09-23 18:50 UTC by Derk-Jan Hartman
Modified: 2012-10-25 09:47 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2011-09-23 18:50:20 UTC
See also: The thumbnail of the original upload has a black background. It contains the following line:


<svg version="1.1" xmlns="http://www.w3.org/2000/svg"  width="300px" height="200px" style="fill:#0072BC">

The most recent upload of the file has as only change a ; after the style comment:
<svg version="1.1" xmlns="http://www.w3.org/2000/svg"  width="300px" height="200px" style="fill:#0072BC;">

The rsvg parser is supposed to force style element termination before feeding it to the css parser, just as the HTML parsers do with style="" attributes.
Comment 1 Derk-Jan Hartman 2011-09-23 19:02:19 UTC
Strike comment 1:

This does NOT work:
<svg version="1.1" xmlns="http://www.w3.org/2000/svg"  width="300px" height="200px" style="fill:#0072BC">
<rect x="0" y="0" width="300px" height="200px"/>


This does work:
<svg version="1.1" xmlns="http://www.w3.org/2000/svg"  width="300px" height="200px">
<rect x="0" y="0" width="300px" height="200px" style="fill:#0072BC;" />
Comment 2 Brion Vibber 2011-09-23 22:30:24 UTC
I can confirm that this isn't handled on what's live... but it appears to be fixed upstream in librsvg.

Rendering them on my dev boxes running rsvg 2.32.1 (Ubuntu 11.04 stock) or 2.34.1 (Ubuntu 11.04 with GNOME 3 installed) renders a nice blue field.
Comment 3 PRO 2011-09-24 16:44:03 UTC
Also most styling as XML attributes don't work anymore (fill=) http://upload.wikimedia.org/wikipedia/commons/1/1d/Testfile.svg
Comment 5 Mark A. Hershberger 2011-09-24 17:12:22 UTC
(In reply to comment #3)
> Also most styling as XML attributes don't work anymore (fill=)
> http://upload.wikimedia.org/wikipedia/commons/1/1d/Testfile.svg

Did this used to work?


Otherwise duping RE:

(In reply to comment #2)
> I can confirm that this isn't handled on what's live... but it appears to be
> fixed upstream in librsvg.
> 
> Rendering them on my dev boxes running rsvg 2.32.1 (Ubuntu 11.04 stock) or
> 2.34.1 (Ubuntu 11.04 with GNOME 3 installed) renders a nice blue field.

*** This bug has been marked as a duplicate of bug 24000 ***
Comment 6 PRO 2011-09-25 22:39:38 UTC
(In reply to comment #5)
> (In reply to comment #3)
> > Also most styling as XML attributes don't work anymore (fill=)
> > http://upload.wikimedia.org/wikipedia/commons/1/1d/Testfile.svg
> 
> Did this used to work?

No this has the bug: [[file:Testfile.svg]]

> *** This bug has been marked as a duplicate of bug 24000 ***

Are now all fixed rsvg bugs in bug 24000??

This bug here is new.
Comment 7 PRO 2011-12-24 15:44:21 UTC
*** Bug 33323 has been marked as a duplicate of this bug. ***
Comment 8 Mark A. Hershberger 2011-12-24 16:38:41 UTC
Re-opening mis-duped bug.  Since the bug was in the version of librsvg that shipped with Lucid, I've back ported the version of librsvg from precise (http://packages.ubuntu.com/precise/librsvg2-2) and submitted it for Ops to review in https://rt.wikimedia.org/Ticket/Display.html?id=2190 since there are some security issues involved.

Hopefully we'll be able to get this taken care of before the new year, but I wouldn't expect too much this weekend.
Comment 9 Mark A. Hershberger 2012-01-04 00:56:43 UTC
An update: I've asked Tim to review the updated package so Ops can push it.
Comment 10 Rob Lanphier 2012-01-25 18:08:34 UTC
Tim fixed a different issue associated with librsvg, but I don't believe that the actual bug referenced here was fixed.  It would be good for someone to file an upstream bug and reference it here.
Comment 11 Mark A. Hershberger 2012-01-26 01:25:30 UTC
(In reply to comment #10)
> It would be good for someone to file
> an upstream bug and reference it here.

Against Ubuntu's Lucid?  The version in Ubuntu's Precise works.
Comment 12 Mark A. Hershberger 2012-01-26 01:29:37 UTC
(In reply to comment #11)
> Against Ubuntu's Lucid?  The version in Ubuntu's Precise works.

Also, I provided patches to backport the version in Precise to Lucid in the RT ticket.  I'm not sure why, if we're willing to patch what we consider security problems, we can't also backport working packages to fix bugs that we experience.
Comment 13 Mark A. Hershberger 2012-01-26 03:20:50 UTC
For completeness, filed an upstream bug with the fix.
Comment 14 Antoine "hashar" Musso (WMF) 2012-02-29 19:54:35 UTC
Migrating bug to Wikimedia > SVG rendering
Comment 15 Antoine "hashar" Musso (WMF) 2012-10-25 09:47:21 UTC
Wikimedia imagescaler have been upgraded to Precise which brings librsvg2 to 2.36. I have uploaded the bugged file http://upload.wikimedia.org/wikipedia/commons/archive/b/bd/20110922210513%21Test.svg as a new file :
https://commons.wikimedia.org/wiki/File:Bug31122-testfile.svg

Renders properly with a blue background. So I guess this bug is now fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links