Last modified: 2011-09-27 00:58:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33100, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31100 - Sidebar parser broken in 1.18
Sidebar parser broken in 1.18
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.18.x
All All
: Highest major (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
: 31123 (view as bug list)
Depends on:
Blocks: 29068
  Show dependency treegraph
 
Reported: 2011-09-22 16:52 UTC by Max Semenik
Modified: 2011-09-27 00:58 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of mw.org with broken sidebar (113.95 KB, image/png)
2011-09-24 19:09 UTC, Krinkle
Details

Description Max Semenik 2011-09-22 16:52:03 UTC
See mediawiki.org: links to subpages are stripped of everything past the slash: Special:Code/MediaWiki|codereview results in a link just to Special:Code.
Comment 1 Brion Vibber 2011-09-22 21:16:45 UTC
Confirmed -- eww! Taking a peek...
Comment 2 Brion Vibber 2011-09-22 21:23:18 UTC
Looks like a regression in r86255 -- changes to Title::fixSpecialName ended up discarding the parameter. Need to check for other similar changes...
Comment 3 Brion Vibber 2011-09-22 21:40:06 UTC
Fixed in r97857 on trunk.

Merged to 1.18 and 1.18wmf1 in r97858, r97859.
Comment 4 Mark A. Hershberger 2011-09-24 17:15:12 UTC
*** Bug 31123 has been marked as a duplicate of this bug. ***
Comment 5 Krinkle 2011-09-24 19:09:02 UTC
Created attachment 9095 [details]
Screenshot of mw.org with broken sidebar

REOPENING. Bug is still happening for some of the sidebar entries. They're not related to subpages of specialpages though. It's the interface / linktext.

MediaWiki is not fetching the message from NS_MEDIAWIKI as it should but splitting out raw message keys (which is the expected fallback)
Comment 6 Bawolff (Brian Wolff) 2011-09-25 01:40:49 UTC
(In reply to comment #5)
> Created attachment 9095 [details]
> Screenshot of mw.org with broken sidebar
> 
> REOPENING. Bug is still happening for some of the sidebar entries. They're not
> related to subpages of specialpages though. It's the interface / linktext.
> 
> MediaWiki is not fetching the message from NS_MEDIAWIKI as it should but
> splitting out raw message keys (which is the expected fallback)

Note (might be useful to whomever is fixing), it seems it does work correctly when you have a different language specified using uselang parameter. see my comment on bug 31123
Comment 7 Aaron Schulz 2011-09-25 07:21:33 UTC
Fixed on MW.org with a MessageCache->singleton()->clear() call in eval.php
Comment 8 Max Semenik 2011-09-25 17:07:38 UTC
Looks like Brion's fixes still need to be deployed.
Comment 9 Aaron Schulz 2011-09-25 20:47:24 UTC
(In reply to comment #8)
> Looks like Brion's fixes still need to be deployed.

Pushed.
Comment 10 Rob Lanphier 2011-09-26 22:02:58 UTC
This seems to be broken still
Comment 11 Brion Vibber 2011-09-26 23:36:09 UTC
The thing with message keys is a separate bug, probably with no relation, and should be split out to another bug report to avoid confusion.

The special: parameter links were a specific actionable thing.
Comment 12 Rob Lanphier 2011-09-27 00:07:29 UTC
Brion filed a separate issue: bug 31177.  There's a discussion underway on #mediawiki to diagnose this.
Comment 13 Tim Starling 2011-09-27 00:58:38 UTC
Clearing the message cache caused it to be fixed, not sure why or if it will happen again.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links