Last modified: 2013-06-13 13:06:29 UTC
Created attachment 9074 [details] JS error I'm using latest version of BookManager and of MW (r97515) and when I access a chater of some book, there is a Javascript error caused by jquery.hotkeys.js. On Google Chrome 13.0.782.220: > http://localhost/mediawiki/extensions/BookManager/client/jquery.hotkeys.js:112 > Uncaught TypeError: Cannot read property 'combi' of null On Firefox 6.02: > data is null @ > http://localhost/mediawiki/extensions/BookManager/client/jquery.hotkeys.js:112 Looking at the call stack on Google Chrome, I see that the error occurs when > $( '#searchInput, #searchInput2, #powerSearchText, #searchText' ) > .suggestions(...) is executed on http://localhost/mediawiki/extensions/Vector/modules/ext.vector.simpleSearch.js This makes the search suggestions not to start when the user types some characters in the search field.
The jquery.hotkeys.js class is a rather old one, and it's overloading jquery.fn.bind() (and breaking it apparently). With the newer jquery interfaces, this should no longer be necessary and this hotkeys implementation should be replaced with the newer implementation: https://github.com/tzuryby/jquery.hotkeys
Fixed by fixing bug 47509.
https://gerrit.wikimedia.org/r/#/c/60367/
