Last modified: 2013-02-18 01:58:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32963, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30963 - Add option to hide redirects on Special:Allpages and Special:Prefixindex
Add option to hide redirects on Special:Allpages and Special:Prefixindex
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Brion Vibber
: patch, patch-need-review
: 7204 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-18 10:20 UTC by Subfader
Modified: 2013-02-18 01:58 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch against trunk (5.14 KB, patch)
2011-12-01 14:09 UTC, MrBlueSky
Details
Patch against trunk (12.09 KB, patch)
2011-12-17 23:38 UTC, MrBlueSky
Details

Description Subfader 2011-09-18 10:20:19 UTC
Please add a new option to Special:Prefixindex to "Hide redirects"
Comment 1 MrBlueSky 2011-12-01 14:09:36 UTC
Created attachment 9590 [details]
Patch against trunk
Comment 2 Iswariya 2011-12-05 10:51:19 UTC
Reply to:

<<MrBlueSky :
Created attachment 9590 [details]
Patch against trunk>>
---------------------------------------------
---------------------------------------------
I have done your code changes in my localhost but am unable to execute it since I get the below error :

""Notice: Undefined variable: request in C:\xampp\htdocs\mediawiki-1.18.0\includes\specials\SpecialPrefixindex.php on line 52

Fatal error: Call to a member function getBool() on a non-object in C:\xampp\htdocs\mediawiki-1.18.0\includes\specials\SpecialPrefixindex.php on line 52""

Could you just tell me that where have you declared the function getBool()??
Comment 3 MrBlueSky 2011-12-05 13:56:21 UTC
getBool() is in WebRequest. But the patch will only work when applied to version 1.19 (trunk).
Comment 4 Sumana Harihareswara 2011-12-15 20:53:13 UTC
MrBlueSky, just wanted to let you know I've asked a developer to review your patch fairly soon.  Thanks and sorry for the wait!
Comment 5 Brion Vibber 2011-12-16 21:10:43 UTC
Try to add new function parameters at the end, rather than in the middle: this'll make it easier on any callers you might not have updated or envisioned.

Since a lot of the implementation and UI is shared between Allpages & Prefixindex, I'd also recommend going ahead and adding the checkbox on Allpages too.

Otherwise looks ok -- go ahead and fix those up and I think it's good to merge.
Comment 6 Sumana Harihareswara 2011-12-16 21:12:33 UTC
Marking reviewed till MrBlueSky responds to code critique.
Comment 7 MrBlueSky 2011-12-17 23:38:02 UTC
Created attachment 9733 [details]
Patch against trunk

Option added to both Prefixindex and Allpages. 

BWT, I noticed that when you submit an empty form on Allpages it takes you to a list of pages instead of showing the overview again (like it does in 1.18). This change seem to be caused by r102406 and might be fixed by:

86c86
< 		} elseif( $from !== null && $to == null ) {
---
> 		} elseif( $from !== null && $to === null ) {

But i'm not sure whether the change was intended and whether this is the best way to fix it.
Comment 8 Subfader 2011-12-20 14:36:10 UTC
Didn't check the patch but the default should be not showing redirects.

Same would be useful for Special:Allpages (worth an own bug report?)
Comment 9 billinghurst 2012-03-02 13:33:29 UTC
Can I ask on the progress of this patch, it would come in very useful.
Comment 10 MrBlueSky 2012-03-03 21:00:45 UTC
(In reply to comment #9)
> Can I ask on the progress of this patch, it would come in very useful.

I'll submit/commit the patch after the move to git, which is scheduled later this month. It should be no problem to get this functionality on Special:Prefixindex and Special:Allpages in version 1.20.
Comment 11 MrBlueSky 2012-03-30 20:42:02 UTC
Done in Gerrit change #3886
Comment 12 Umherirrender 2012-08-04 22:19:25 UTC
*** Bug 7204 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links