Last modified: 2014-07-08 12:52:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32954, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30954 - mwsuggest should support a .mw-search classname instead of hardcoded ids
mwsuggest should support a .mw-search classname instead of hardcoded ids
Status: NEW
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
1.20.x
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-17 15:58 UTC by Daniel Friesen
Modified: 2014-07-08 12:52 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Friesen 2011-09-17 15:58:21 UTC
Currently mwsearch only supports the ids #searchform, #searchform2, #powersearch, and #search.

We should update mwsearch to use jQuery and add support for a .mw-search class name on the form to indicate a search form intended to search the wiki instead of requiring that custom skins use these hardcoded ids.

mwsearch looks a little big for me to just pickup and convert. It's also fairly focused around id's so it doesn't look easy to just convert to using a class without going ahead and converting most of it to jQuery.

Also, instead of hardcoding the ids of search inputs we should be using <code>$( theForm ).find(':input[name="search"]')</code> to fetch the search input.
Comment 1 Brion Vibber 2011-09-19 15:19:36 UTC
Can you clarify what you mean by mwsearch? The MWSearch extension supplies backend support for the Lucene search server, but it sounds like you're referring to the setup of type-ahead suggestions on search fields (a feature that is sometimes known as mwsuggest).
Comment 2 Daniel Friesen 2011-09-19 18:17:16 UTC
Sorry I typed mwsearch when I meant mwsuggest. I'm referring to our /skins/common/mwsuggest.js code which uses hardcoded ids.

Though I'm now aware that Vector also has completely different search suggest code so I'm not sure if making that work as a replacement for mwsuggest would be better.
Comment 3 Chad H. 2014-05-30 22:05:27 UTC
How relevant is this nowadays since we don't use mwsuggest and use simplesearch?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links