Last modified: 2011-09-16 00:55:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32922, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30922 - DumpHTML "Latest revision" link oddities with protocol-relative URLs
DumpHTML "Latest revision" link oddities with protocol-relative URLs
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
DumpHTML (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 20342
  Show dependency treegraph
 
Reported: 2011-09-16 00:05 UTC by Brion Vibber
Modified: 2011-09-16 00:55 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-09-16 00:05:14 UTC
When using protocol-relative links in $wgServer along with DumpHTML extension, the 'Latest revision' tab can end up breaking when viewing the pages on the local filesystem:

<a href="//stormcloud.local/trunk/index.php/Main_Page">Latest revision</a>

ends up resolving the URL in the browser to something like:

file:///trunk/index.php/Main_Page

which doesn't work too well.

Should probably use $title->getCanonicalURL here.
Comment 1 Brion Vibber 2011-09-16 00:55:27 UTC
r97226 clears this up; uses wfExpandURL(x, PROT_CANONICAL) when slurping in the old article path (later used to generate the links).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links