Last modified: 2014-02-12 23:53:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32887, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30887 - Inline Styles: Portal pages need to be redesigned for mobile
Inline Styles: Portal pages need to be redesigned for mobile
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Low major
: ---
Assigned To: Nobody - You can work on this!
:
: 22187 (view as bug list)
Depends on:
Blocks: inline-styles
  Show dependency treegraph
 
Reported: 2011-09-13 18:48 UTC by Tomasz Finc
Modified: 2014-02-12 23:53 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tomasz Finc 2011-09-13 18:48:08 UTC
Totally broken since we impose fixed width.

http://en.m.wikipedia.org/wiki/Portal:Xbox
Comment 1 Brion Vibber 2012-01-12 00:11:17 UTC
See bug 32123 for a bunch of info about fixing these portal pages; some have been cleaned up, others need to be done still.
Comment 2 Jon 2012-04-10 00:37:17 UTC
See bug 35704
Comment 3 Jon 2012-05-17 13:51:43 UTC
It's better as now the table is horizontally scrollable but still messy.

Several problems:
* Section toggling is not enabled. For some reason content of a section appears as a div outside the .content_block div rather than inside it
* There seems to be a need for a PortalTemplate to take away the need for inline styling
Comment 4 Jon 2012-06-02 16:18:35 UTC
So I've cleaned up lots of portal pages [1,2,3]

I think next step is to get a list of all pages which have known bad styles
To do this we should download one of the latest dumps [4] and grep them for the following known patterns:
float:left; width:60%
float:left; width:51%;
float:right; width:48%
and then edit those articles so that they use classes instead.

Gabrielle Wicke has several node grepping tools [4] that will help us do this
I'll report back with a list of bad pages so we can clean these up.

[1] http://en.wikipedia.org/w/index.php?title=Wikipedia:WikiProject_Microsoft&diff=prev&oldid=495628088
[2] http://en.wikipedia.org/w/index.php?title=Portal:Xbox&diff=prev&oldid=495624606
[3] http://en.wikipedia.org/w/index.php?title=Portal:Missouri&diff=prev&oldid=495624262
[4] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/VisualEditor.git;a=tree;f=tests/parser;h=daa09af44d1aaebbe3a5aa3d4a1b77b8e2531be9;hb=HEAD
Comment 5 Phil Chang 2012-06-03 05:17:15 UTC
Nice, but hard work. I wonder if we should stir up some community help, as we will shortly do with the default switchover of the sister projects?
Comment 6 Jon 2012-06-04 20:37:42 UTC
Here is a list of effected pages on English Wikipedia:
http://www.mediawiki.org/wiki/List_of_Problematic_portal_pages_with_two_column_layouts

Please help clean these up to close this bug.
Comment 7 Jon 2012-06-06 11:12:53 UTC
Added fix to MobileFrontend stylesheet https://gerrit.wikimedia.org/r/#/c/10414/
Comment 8 Jon 2012-07-03 18:55:13 UTC
Another example of a page with an inline style problem:
http://en.m.wikipedia.org/w/index.php?title=New_Haven_Line

$("[style]").removeAttr("style") fixes it
Haven't got time right now to explore this further
Comment 9 Jon 2012-08-03 23:50:09 UTC
All portal pages are now fixed via a grease monkey script
https://gist.github.com/3252773
Comment 10 Jon 2012-09-18 04:59:39 UTC
*** Bug 22187 has been marked as a duplicate of this bug. ***
Comment 11 Krinkle 2012-10-10 22:35:38 UTC
-dependency (which is marked duplicate)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links