Last modified: 2012-10-26 23:46:41 UTC
The devanagari diacritics that appear below the alphabets are cut off in article titles and headings with border-bottom(the grey line) in hindi wikipedia. The problem is present in the vector and monobook skins atleast. Haven't checked out the other skins yet. In the vector skin, the problem might be with the padding-bottom for these. The solution would require browser-specific css. The headings problem can be seen(even by those who dont recognise devanagari at http://hi.wikipedia.org/wiki/%E0%A4%B8%E0%A4%A6%E0%A4%B8%E0%A5%8D%E0%A4%AF:Siddhartha_Ghai/sandbox05 ).
Created attachment 9026 [details] Windows 7 Home Basic SP1, Chrome 13.0.782.220 m, vector skin
Created attachment 9027 [details] Windows 7 Home Basic SP1, Firefox 6.0, vector skin
This ultimately looks similar to bug 29405, though on the other side -- there the risers go too far up and get cut off, here the descenders go too far down and get cut off. In both cases, the header element has an 'overflow: hidden' style, which causes anything going outside the box area to get clipped and hidden instead of spilling over the edge. Note that I have trouble reproducing this cutoff issue on my Linux or Mac machines, but can definitely see it on Windows. Seems to vary depending on the font & font rendering system, you end up with less or more space...
Created attachment 9028 [details] Windows 7 Home Basic SP1, IE8.0.7601.17514, vector skin
Created attachment 9029 [details] Windows 7 Home Basic SP1, Opera 11.50, vector skin This is the only one without a problem that I've seen so far.
Created attachment 9030 [details] Windows 7 Home Basic SP1, Safari 5.0.3(7533.19.4), vector skin
Created attachment 9031 [details] Windows 7 Home Basic SP1, Chrome 13.0.782.220 m, monobook skin
Created attachment 9032 [details] Windows 7 Home Basic SP1, Firefox 6.0, monobook skin
Created attachment 9033 [details] Windows 7 Home Basic SP1, IE8.0.7601.17514, monobook skin
Created attachment 9034 [details] Windows 7 Home Basic SP1, Opera 11.50, monobook skin Again, this is the only one which works.
Created attachment 9035 [details] Windows 7 Home Basic SP1, Safari 5.0.3(7533.19.4), monobook skin
*** This bug has been marked as a duplicate of bug 29405 ***
Bug 29405 only lists the problem with the article title, not that with the section headings. r97788 fixes only the title, not the section headings. Also, the problem might arise anywhere there's a top or bottom border, but I haven't checked that yet.
Discussed this with Trevor, and he proposed language specific css rules, otherwise it will affect other languages too. r97788 was reverted and r99389 addresses this in language specific way. Will get it reviewed by Trevor again.
Closing this a little late, but fixes were made in r99389, r104160, r105517, r105521.
(In reply to comment #15) > Closing this a little late, but fixes were made in r99389, r104160, r105517, > r105521. Problem is down but not out. The #firstHeading property(line-height:1.2em) seems to be overriding the language-specific css(line-height:1.5em). I'm seeing this behaviour in chrome 16.0.912.63 m and firefox 8.0 with windows 7 Home Basic X64 SP1. However, adding an !important to the language-specific css seems to solve the problem.
Created attachment 9747 [details] Chrome 16.0.912.63 m behaviour Attachment for comment 16
Created attachment 9748 [details] Chrome 16.0.912.63 m behaviour with !important Attachment for comment 16 showing possible fix.
Santhosh, can you have a look at this? IIRC we did add an !important somewhere already...
Addressed in r108215.
