Last modified: 2005-08-23 18:37:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3064 - Refactor EditPage::editForm
Refactor EditPage::editForm
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks: code_quality
  Show dependency treegraph
Reported: 2005-08-06 22:19 UTC by Alan
Modified: 2005-08-23 18:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Factored out confirmDelete() (2.15 KB, patch)
2005-08-06 22:23 UTC, Alan
Factored out confirmDelete() (2.15 KB, patch)
2005-08-06 22:29 UTC, Alan

Description Alan 2005-08-06 22:19:40 UTC
The trunk version of EditPage::editForm is currently a roughly 500-line function
that builds the Edit page in all its various manifestations.  Its large size and
number of variations (preview, diff, new article, edit conflict, etc.) make it
difficult to understand and improve.  The function should be refactored so that
the bulk of its code is handed off to auxiliary functions, and what remains is
clear enough to follow the logic in building the edit form.
Comment 1 Alan 2005-08-06 22:23:27 UTC
Created attachment 763 [details]
Factored out confirmDelete()
Comment 2 Alan 2005-08-06 22:27:48 UTC
Comment on attachment 763 [details]
Factored out confirmDelete()

Attachment 763 [details] has a bug.  I will resubmit it.
Comment 3 Alan 2005-08-06 22:29:03 UTC
Created attachment 764 [details]
Factored out confirmDelete()

Corrected version of earlier patch 763.
Comment 4 Brion Vibber 2005-08-23 18:37:33 UTC
This function was recently refactored, so patch will probably not apply.

Note You need to log in before you can comment on or make changes to this bug.