Last modified: 2005-08-23 18:37:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5064, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 3064 - Refactor EditPage::editForm
Refactor EditPage::editForm
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.6.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2005-08-06 22:19 UTC by Alan
Modified: 2005-08-23 18:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Factored out confirmDelete() (2.15 KB, patch)
2005-08-06 22:23 UTC, Alan 		Details
Factored out confirmDelete() (2.15 KB, patch)
2005-08-06 22:29 UTC, Alan 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Alan 2005-08-06 22:19:40 UTC 
The trunk version of EditPage::editForm is currently a roughly 500-line function
that builds the Edit page in all its various manifestations.  Its large size and
number of variations (preview, diff, new article, edit conflict, etc.) make it
difficult to understand and improve.  The function should be refactored so that
the bulk of its code is handed off to auxiliary functions, and what remains is
clear enough to follow the logic in building the edit form.
Comment 1 Alan 2005-08-06 22:23:27 UTC 
Created attachment 763 [details]
Factored out confirmDelete()
Comment 2 Alan 2005-08-06 22:27:48 UTC 
Comment on attachment 763 [details]
Factored out confirmDelete()

Attachment 763 [details] has a bug.  I will resubmit it.
Comment 3 Alan 2005-08-06 22:29:03 UTC 
Created attachment 764 [details]
Factored out confirmDelete()

Corrected version of earlier patch 763.
Comment 4 Brion Vibber 2005-08-23 18:37:33 UTC 
This function was recently refactored, so patch will probably not apply.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links