Last modified: 2014-02-12 23:38:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32622, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 30622 - [SignupAPI] LocalSettings should not be ignored
[SignupAPI] LocalSettings should not be ignored
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
SignupAPI (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Akshay Agarwal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-08-29 21:20 UTC by Krinkle
Modified: 2014-02-12 23:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2011-08-29 21:20:23 UTC 
The main PHP file of the extension defines $wgSignupAPIUseAjax and $wgSignupAPISourceTracking (set to true by default).

The problem is that no matter what one puts in LocalSettings these are always used as if they are set to true.

The reason is because they are used from within the main php file. The LocalSetting seems ignored because the variables are used to soon (rather than from within a class method when the information must be known).
Comment 1 Krinkle 2011-08-29 21:24:30 UTC 
$wgSignupAPIUseAjax  is fixed in r95701. The variable is now checked in SpecialUserSignup->execute() which is still soon enough, but way after LocalSettings is initialized.
Comment 2 Akshay Agarwal 2012-09-06 14:51:56 UTC 
This has been fixed here https://gerrit.wikimedia.org/r/#/c/22861/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links