Last modified: 2011-11-17 19:44:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32244, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30244 - Use HTML5 FileAPI to read individual files for upload
Use HTML5 FileAPI to read individual files for upload
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 24759 26502 29250 30242
  Show dependency treegraph
 
Reported: 2011-08-05 12:37 UTC by Brion Vibber
Modified: 2011-11-17 19:44 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-08-05 12:37:18 UTC
We already use HTML5's FileApi for thumbnails when available (bug 29248), but we could also perform the actual uploads by reading via FileApi and then pushing up.

This would be a requirement for resumable downloads (bug 29250)

and even without changing protocols should enable better upload progress feedback since we can follow the progress of an XHR submission better than an iframe (bug 24759, bug 30242).

Would also allow implementing multi-file uploads (bug 26502) without changing server-side API support to handle multiple files in one POST (bug 16751 etc).
Comment 1 Neil Kandalgaonkar 2011-08-08 18:35:17 UTC
You seem to be proposing an implementation to fix another bug in this bug. Maybe this should not be a bug in itself?

It could still be possible to rewrite the upload API method to accept multiple files, especially if these files go directly to stash and do not need their own title or other metadata. That would give us a sort of multiple file support for IE <= 9 and other pre-2010 browsers.

However, the XHR/FileReader method is definitely desirable because that gives us much more flexibility and we can start multiple uploads at once, rather than wait for the browser to do them all in sequence. That will work for modern Chrome and Firefox and (hopefully) IE>=10.

In principle we can do both, but the implementation is complicated. I've tried to keep a huge wall of separation between "UploadWizardUploadInterface" and "UploadWizardUpload" and the "transports" that each use, for this reason. Considering IE is getting this in version 10 it might be simpler to do everything the FileReader way.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links