Last modified: 2013-05-29 00:44:12 UTC
OutputPage.php checks $wgUseAjax and some module specific configuration variables ($wgAjaxWatch, $wgEnableMWSuggest) before it includes javascript using AJAX. But $wgUseAjax isn't necessary, since these scripts don't use action=ajax any more. Instead it should check $wgEnableAPI (and $wgEnableWriteAPI for features that need it, like watching). Both $wgEnableAPI and $wgEnableWriteAPIshould should also be checked together with $wgUseAJAXCategories.
Hmm, $wgEnableAPI and $wgEnableWriteAPI should probably go away entirely at this point -- the API is generally assumed to always be on and usable these days, and lots of JS-side stuff depends on it.
I agree. Though maybe ask on mediawiki-l for people that still use it and look at the possible use cases ?
http://lists.wikimedia.org/pipermail/mediawiki-l/2011-August/037842.html
Brion, Krinkle: I sent in Gerrit change #63259 to remove the settings, and it was pointed out that "[...] there's been no [current?] discussion around this, and it's actually supported just fine [...] that's the tool's fault, not a disabled API's fault." I suppose I could bring this up on relevant mailing lists, though before doing so, I'll note that some expressed concern about what this change might mean for two groups of wikis: a) private wikis and b) wikis that want to prevent users from exporting their articles. Do you still believe these settings ought to be removed? Or should some $wgEnableAPI && $wgEnableWriteAPI checks be added throughout the codebase, as stated in comment 0?
Related URL: https://gerrit.wikimedia.org/r/65785 (Gerrit Change If2ec219cfbb94e7c9718c58b9b54a508d0e0c656)
Change merged.
