Last modified: 2011-08-19 11:28:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31993, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29993 - E-mail notification should work with protocol relative urls
E-mail notification should work with protocol relative urls
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Email (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 30204 (view as bug list)
Depends on:
Blocks: 20342
  Show dependency treegraph
 
Reported: 2011-07-21 01:26 UTC by Krinkle
Modified: 2011-08-19 11:28 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2011-07-21 01:26:52 UTC
Discovered on wikitech, when the server hostname is configured with a relative protocol, the mails sent are broken.

It should either default to a configuration variable, a user preference or whatever the request triggering the mail had as protocol.

The problem with the latter is that it results in inconsistent e-mail (ie. user John get's mixed urls in his emails, some http some https one of which he is mostly likely not logged in at)
Comment 1 Roan Kattouw 2011-08-09 16:52:09 UTC
This should be fixed with r93891, but I didn't test that. Can someone confirm?
Comment 2 Roan Kattouw 2011-08-10 14:50:03 UTC
*** Bug 30204 has been marked as a duplicate of this bug. ***
Comment 3 Roan Kattouw 2011-08-15 23:25:11 UTC
(In reply to comment #1)
> This should be fixed with r93891, but I didn't test that. Can someone confirm?
Deployed the fix, and confirmed it on testwiki by asking Ryan to edit my talk page.
Comment 4 Roan Kattouw 2011-08-15 23:32:10 UTC
Turns out to be only semi-fixed. The primary URL is fixed now, but the footer reads:

--
To change your email notification settings, visit
//test.wikipedia.org/wiki/Special:Preferences

To change your watchlist settings, visit
//test.wikipedia.org/wiki/Special:Watchlist/edit

To delete the page from your watchlist, visit
http://test.wikipedia.org/w/index.php?title=User_talk:Catrope&action=unwatch

Feedback and further assistance:
//test.wikipedia.org/wiki/Help:Contents
Comment 5 Roan Kattouw 2011-08-19 11:28:23 UTC
(In reply to comment #4)
> Turns out to be only semi-fixed. The primary URL is fixed now, but the footer
> reads:
> 
> --
> To change your email notification settings, visit
> //test.wikipedia.org/wiki/Special:Preferences
> 
Those were particularly nasty, because the i18n message looked like this:

To change your email notification settings, visit
{{fullurl:{{#special:Preferences}}}}

Fixed in a somewhat elaborate way, as part of a reorganization that needed to be done anyway, in r94995.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links