Last modified: 2012-03-17 08:54:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31835, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29835 - Enable Extension:CustomSidebar on Hindi Wikipedia
Enable Extension:CustomSidebar on Hindi Wikipedia
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 29839 (view as bug list)
Depends on:
Blocks: 29823
  Show dependency treegraph
 
Reported: 2011-07-12 11:59 UTC by Vaibhav Jain
Modified: 2012-03-17 08:54 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Vaibhav Jain 2011-07-12 11:59:03 UTC
Please enable Extension:CustomSidebar on Hindi Wikipedia. The local consensus is here:
http://hi.wikipedia.org/wiki/विकिपीडिया:New_Extension
Comment 1 p858snake 2011-07-12 12:10:47 UTC
This would break parser caching.
Comment 2 Mayur 2011-07-12 12:15:46 UTC
No, I think no problem with this at all with mediawiki ,as this exetension is already being used by Bharatakosh(http://hi.bharatdiscovery.org/india/%E0%A4%B5%E0%A4%BF%E0%A4%B6%E0%A5%87%E0%A4%B7:Version), nothing happened there.Plz reconfirm it
Comment 3 Vaibhav Jain 2011-07-12 12:20:43 UTC
Hindi Wikipedia community has no problem with this, so why other users have
which are not effected with this.
Comment 4 Sam Reed (reedy) 2011-07-12 19:04:44 UTC
*** Bug 29839 has been marked as a duplicate of this bug. ***
Comment 5 Brion Vibber 2011-07-13 00:53:58 UTC
'Local consensus' link leads to a nonexistent page.

Assuming this is about http://www.mediawiki.org/wiki/Extension:CustomSidebar ...

Source is not in our SVN, so it would need to be copied & reviewed prior to any potential deployment.

I really don't like this extension however; per-page sidebar tweaks aren't really how the sidebar's generally meant to be used, and the current sidebar syntax is sufficiently *horrible* to use that I really really wouldn't want to start hardcoding that in more places.

The system for pulling the sidebar info from the page seems to explicitly deal with parser caching not by using MediaWiki's own systems (for instance, saving the relevant information with the ParserOutput object and then pulling it out from the cached object) but by simply hiding the sidebar chunk in the parsing, then during the skin's sidebar processing it *expands templates and variables, strips comments, finds the sidebar chunk, and then processes that. THis feels very.... icky!

It also seems to interact with $wgEnableSidebarCache by .... saving a single sidebar cache per language for the entire site. This seems like it will not actually work?


I definitely recommend against this extension or anything that works like it does.

If custom sidebar lines need to be added in only a few specific cases, you can do this now using site JS to conditionally append items to the sidebar (or site CSS to conditionally show/hide a line based on page title or a couple other things).

If there's a real, specific need that's different, please go into details about the actual requirements and we'll see whether something that fits Wikimedia's performance and security needs better without messing anything up could be devised. (Personally I would recommend against anything along these lines though.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links