Last modified: 2014-11-17 10:35:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31786, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29786 - LQT shouldn't accept duplicated posts on the same page/thread
LQT shouldn't accept duplicated posts on the same page/thread
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Low normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/Thread:...
:
: 26705 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-09 13:30 UTC by Helder
Modified: 2014-11-17 10:35 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2011-07-09 13:30:34 UTC
I don't know if this was already reported but the extension shouldn't let users to (accidentally) submit duplicated posts (something which is common when the internet connection is slow), such as this
http://www.mediawiki.org/wiki/Thread:Talk:Article_feedback/Delete/reply_(18)
Comment 1 Helder 2011-07-28 17:55:16 UTC
This is still happening. E.g.: [[mw:Thread:Talk:MoodBar/Ideas log (2)]].
Comment 2 TBloemink 2011-09-23 06:01:36 UTC
I don't think this can happen without clicking the reply button twice, or can it?
Comment 3 Helder 2011-09-23 14:22:30 UTC
(In reply to comment #2)
> I don't think this can happen without clicking the reply button twice, or can
> it?

Yep, but for users with slow connections, it is very common to see that spinner image running forever (see Bug 26290), meaning that the content was not sent yet. In those cases the only option the user have if he wants to post his reply is to send it again (without knowing if the first try was successfully submited). And this cause the duplicated threads. This is very common:

http://www.mediawiki.org/w/index.php?title=Special%3ALog&type=delete&user=&page=Thread%3ATalk%3AArticle+feedback%2FIrrelevant%2Freply+%2834%29&year=&month=-1&tagfilter=

http://www.mediawiki.org/w/index.php?title=Special%3ALog&type=delete&user=&page=Thread%3AProject%3ASupport+desk%2FI+can%27t+create+new+items+in+Mediawiki+%282%29&year=&month=-1&tagfilter=

http://www.mediawiki.org/w/index.php?title=Special%3ALog&type=delete&user=&page=Thread%3AProject%3ASupport+desk%2FHow+powerful+is+MediaWiki+for+the+following+listed+uses...%3F&year=&month=-1&tagfilter=
Comment 4 sheac 2012-05-04 16:41:48 UTC
This bug has not been touched in at least six months. With this in mind, I've been asked by the bugmeister to bump this bug's priority down for "High". Concerns can be addressed to mah@everybody.org.

Also, there is some indication above that the bug is a duplicate. Has this possibility been ruled out?
Comment 5 Helder 2012-05-04 17:31:36 UTC
(In reply to comment #4)
> Also, there is some indication above that the bug is a duplicate. Has this
> possibility been ruled out?

Duplicate of which bug?
Comment 6 sheac 2012-05-04 21:17:34 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Also, there is some indication above that the bug is a duplicate. Has this
> > possibility been ruled out?
> 
> Duplicate of which bug?

I'm making reference to the following quote in the bug description:

    "I don't know if this was already reported but..."
Comment 7 Helder 2012-05-04 21:35:53 UTC
Ah, ok.

Looking at
https://bugzilla.wikimedia.org/buglist.cgi?component=LiquidThreads&list_id=112920
I see the following bugs which may be related:
* Bug 30222 - LiquidThreads creates thread duplicates when used with WikEd
* Bug 19145 - Reduce duplicate LQT posts caused by re-submitting the same form

Maybe Bug 19145 should be REOPENED (since r52454 didn't fix the problem) and this bug and bug 30222 be marked as duplicated of that?
Comment 8 Helder 2012-08-05 20:49:25 UTC
*** Bug 26705 has been marked as a duplicate of this bug. ***
Comment 10 Helder 2014-01-28 15:58:06 UTC
Ping. This is still happening relatively often.

MariaDB [mediawikiwiki_p]> SELECT COUNT(*) AS DUPES FROM logging WHERE log_type = 'delete' AND log_namespace = 90 AND log_comment LIKE 'du%';
+-------+
| DUPES |
+-------+
|    71 |
+-------+
1 row in set (0.12 sec)

MariaDB [mediawikiwiki_p]> SELECT COUNT(*) AS DUPES FROM logging WHERE log_type = 'delete' AND log_namespace = 90 AND log_comment LIKE 'Du%';
+-------+
| DUPES |
+-------+
|    20 |
+-------+
1 row in set (0.11 sec)
Comment 11 Gerrit Notification Bot 2014-04-04 07:56:35 UTC
Change 123836 had a related patch set uploaded by Adi.iiita:
LQT should not accept duplicate post

https://gerrit.wikimedia.org/r/123836
Comment 12 Gerrit Notification Bot 2014-08-28 17:51:49 UTC
Change 123836 abandoned by Krinkle:
LQT should not accept duplicate post

https://gerrit.wikimedia.org/r/123836

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links