Last modified: 2013-02-09 18:16:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31582, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29582 - UploadWizard needs explicit {{GRAMMAR}} support
UploadWizard needs explicit {{GRAMMAR}} support
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n, parser
Depends on: 20962
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-25 15:10 UTC by Pavel Selitskas [wizardist]
Modified: 2013-02-09 18:16 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Pavel Selitskas [wizardist] 2011-06-25 15:10:13 UTC
After file is uploaded in UploadWizard (step 2), UW fails to move to the next step.

There is an error message in Chrome Developer Tools console: "Uncaught Error: Parse error at position 183 in input: Гэта выглядае як файл, які Вы атрымалі з іншага сховішча файлаў. Калі ласка, зрабіце назву больш зьмястоўнай. Акрамя таго, двойчы праверце, што ў Вас ёсьць дазвол на яго публікацыю ў {{GRAMMAR:месны|{{SITENAME}}}}." This is {{int:Mwe-upwiz-error-title-hosting}} in be-tarask locale.

UploadWizard doesn't support {{GRAMMAR}}, so the only work-around for a while is to get rid of {{GRAMMAR}} tags in messages. Perhaps, It makes sense for English - for Belarusian, Russian and other Slavic languages it does not.

There are two ways: either make UploadWizard support GRAMMAR rules, or shut it up and display wrapped contents ({{SITENAME}} in this example) until we clean all the messages in UploadWizard directory. The first way is preferrable, of course :-)

Without such a fix UploadWizard is not usable in locales where {{GRAMMAR}} is intended.
Comment 1 Leinad 2011-08-28 00:43:35 UTC
Hi,

Is there any progess to fix this bug?
Comment 2 Leinad 2011-08-28 00:45:14 UTC
PS Also in Polish version {{GRAMMAR}} brokes UploadWizard.
Comment 3 Erik Moeller 2011-09-02 17:06:26 UTC
Escalating priority.
Comment 4 Erik Moeller 2011-09-02 17:20:24 UTC
On Wikimedia Commons, please substitute the message in the MediaWiki: namespace for now to not use the grammar keyword, or point me to the relevant messages so I can do so (User:Eloquence on Commons). We'll look into adding grammar support ASAP.

See
http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/UploadWizard/UploadWizard.i18n.php?revision=96108&view=markup for a full list of relevant MW messages.
Comment 5 Siebrand Mazeland 2011-09-02 18:08:42 UTC
I have changed all occurences of {{SITENAME}} to "this site" for the messages of the UploadWizard in r96131. I also removed any usage of GRAMMAR in the same file, and removed those messages in translatewiki.net. Roan is backporting r96131 to 1.17wmf. After that he will deploy it and run LocalisationUpdate, so the issue is gone for now.

Erik has requested Neil, the head developer of the UploadWizard and me to get GRAMMAR support in the JavaScript parts of MediaWiki. That may not be that simple, but we'll keep you updated here!
Comment 6 Mark A. Hershberger 2011-09-06 20:34:16 UTC
The failure here looks similar if not identical to Bug 30707.  {{GRAMMAR}} support is a separate issue, though.
Comment 7 sheac 2012-05-04 21:34:53 UTC
This bug has not been touched in at least six months. With this in mind, I've been asked by the bugmeister to bump this bug's priority down for "High". Concerns can be addressed to mah@everybody.org.
Comment 8 Thehelpfulone 2012-06-22 19:41:04 UTC
Reassigning to wikibugs-l per bug 37789
Comment 9 Mark Holmquist 2012-08-23 20:49:43 UTC
I'm going to go ahead and take a stab, and say that this is related to the fact that JavaScript messages aren't handled very well. If that's the case, maybe we should be filing bugs against MediaWiki/JavaScript.
Comment 10 Siebrand Mazeland 2012-08-24 07:23:24 UTC
Hi Mark. From the bug triage I can remember that it's basically using the wrong i18n calls in UploadWizard. It's using a lot of gM() where it should be using mw.msg().

Core doesn't use this method, and only a few remaining extensions use it (EducationProgram, Contest, PageTriage, UploadWizard).
Comment 11 Mark Holmquist 2012-08-24 20:11:25 UTC
OK! Things I learned today!

I'll try to whip up a patch for this after lunch, should be quickish.
Comment 12 Pavel Selitskas [wizardist] 2012-11-07 04:34:24 UTC
As long as mw.language.convertGrammar works just fine, this ticket may be considered as RESOLVED.
Comment 13 Derk-Jan Hartman 2012-11-09 08:15:07 UTC
gM now maps to mw.jqueryMsg.getMessageFunction since 82d61f796a4d24adaf8419ecdbb333496be2c3f0

So is that the right function ? Do we possible want to do actual replacing of gM() everywhere ?

Do we need to revert  r96131 that removed {{SITENAME}} and {{GRAMMER}} from the UW messages ? On first sight it seems that the message reverted there are now all in place again, but not 100% sure.
Comment 14 Siebrand Mazeland 2012-11-09 09:45:48 UTC
(In reply to comment #13)
> Do we possible want to do actual replacing of
> gM() everywhere ?

Yes.

> Do we need to revert  r96131 that removed {{SITENAME}} and {{GRAMMER}} from the
> UW messages ? On first sight it seems that the message reverted there are now
> all in place again, but not 100% sure.

Yes.
Comment 15 Nischay Nahata 2013-02-09 17:29:18 UTC
Is someone working on this anymore? anyway the summary isn't valid anymore, only some text replacement has to be made
Comment 16 Nemo 2013-02-09 18:16:02 UTC
Fixed summary.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links