Last modified: 2014-06-13 12:03:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31552, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29552 - Squid cache of redirect pages don't get purged when page it redirects to gets edited
Squid cache of redirect pages don't get purged when page it redirects to gets...
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
: testme
: 30440 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-23 18:51 UTC by Bex Young
Modified: 2014-06-13 12:03 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bex Young 2011-06-23 18:51:19 UTC
The Teach For America page is not showing the most recent edits that I made. If I am logged in, everything shows up newly edited...if I am logged out, it does not.

I thought it might be cookies so I asked others to check, they do not see the new version of the page. 

Link to page: http://en.wikipedia.org/wiki/Teach_for_america

noted areas of discrepancy:
Geographical reach
Alumni

Would love to know if this is something I am doing wrong when editing - but I believe all edits should go live immediately.

Thanks!

Bex
Comment 1 Mark A. Hershberger 2011-06-24 18:05:45 UTC
What you're seeing sounds like the normal result of FlaggedRevs use on Wikipedia. http://www.mediawiki.org/wiki/Extension:FlaggedRevs
Comment 2 Bawolff (Brian Wolff) 2011-06-24 18:17:05 UTC
The page isn't using flagged revs, (where that behaviour would be normal), so
the edits should appear immediately... (see review log http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=review&user=&page=Teach+For+America&year=&month=-1&tagfilter=&hide_patrol_log=1&hide_review_log=1 )

Some sort of caching issue maybe?
Comment 3 Mark A. Hershberger 2011-06-24 18:24:26 UTC

*** This bug has been marked as a duplicate of bug 27891 ***
Comment 4 Bawolff (Brian Wolff) 2011-06-24 18:25:30 UTC
Appears to be a squid cache entry that was not cleared.

Can reproduce when logged out (and have cookies cleared) when viewing the redirected page [[Teach for america]] (but not the actual [[Teach For America]] page).
Comment 5 Mark A. Hershberger 2011-06-24 18:32:06 UTC
Thanks for tracking that bit down, Bawolff!
Comment 6 Bawolff (Brian Wolff) 2011-06-24 19:03:03 UTC
I was able to reproduce on testwiki.

Steps to reproduce:
*Create page 1 ([[test:User:Bawolff/bug29552]])
*Create page 2 redirecting to page 1 ([[test:User:Bawolff/bug29552-redir]])
*Look at both of them in a browser where you are not logged in.
*Edit page 1 a couple times
*Look at page 1 in the non-logged in browser. Its still the old version. page 2 is updated, and if you append a random query parameter to the url of page 1 its the new version. I believe this indicates that the squid cache is not being cleared for the redirect.

Expected behaviour:
Something in the job queue sends squid purge request for any page that redirects to the edited page.
Comment 7 Bawolff (Brian Wolff) 2011-06-25 04:00:11 UTC
So, as far as I can tell, this should be done by Article::onArticleEdit (which call's HTMLCacheUpdate, which purges squid cache of everything that redirects to the article). I have no idea why it wouldn't be happening. I don't think it should trigger the job queue since there's only a single redirect in my test case. (I don't have squid set up locally, so its kind of hard to test)
Comment 8 Bawolff (Brian Wolff) 2011-07-05 00:47:52 UTC
I can confirm on my local install of /branches/wmf/1.17wmf1 (with squid) and using the mediawiki config of:
$wgUseSquid = true;
$wgHTCPMulticastAddress = '127.0.0.1';

That HTCP purges are sent correctly, squid kills the relevant entries from cache when it gets the HTCP packet. 


So perhaps its something to do with Wikimedia's squid set up (Its certainly more complex than my test setup). However, that'd be weird, because it purges the direct page fine, its just the dependant redirects that don't get purged. Perhaps related to bug 28613. In any case there's not that much more I can really do to test this so unassigning from self.
Comment 9 Bawolff (Brian Wolff) 2011-07-08 17:10:32 UTC
bug 28613 comment 40 says the issue that I thought might be potentially causing this issue is fixed, however this issue is still present on Wikimedia (tested on test.wikipedia.org)

/me really has no idea whats going on with this.
Comment 10 Dirk Beetstra 2011-07-14 10:14:03 UTC
I have a question on my talkpage regarding something similar.  Redirects that get re-redirected also do not seem to go to the correct target unless the cache is flushed (this is an IP editor).

See http://en.wikipedia.org/w/index.php?title=User_talk:Beetstra&oldid=439412339#Homatropine.2FMethylhomatropine_wrong_redirect
Comment 11 Bawolff (Brian Wolff) 2011-09-08 14:02:27 UTC
*** Bug 30440 has been marked as a duplicate of this bug. ***
Comment 12 Derk-Jan Hartman 2011-12-05 14:42:44 UTC
Moved this into Wikimedia, as per testing of Bawolff, this seems wikimedia specific.
Comment 13 Liangent 2012-06-03 06:00:00 UTC
Gerrit change #9877
Comment 14 Liangent 2012-06-03 17:36:17 UTC
It's not the issue I thought of...
Comment 15 Bawolff (Brian Wolff) 2012-12-14 22:43:30 UTC
I have no idea what the original cause was, but since sept 2011 see bug 38879  comment 11
Comment 16 MZMcBride 2012-12-22 03:57:48 UTC
I hit this issue fairly frequently on the English Wikipedia.
Comment 17 Nemo 2013-04-04 21:12:29 UTC
(In reply to comment #15)
> I have no idea what the original cause was, but since sept 2011 see bug
> 38879 
> comment 11

job/jobs/HTMLCacheUpdateJob.php hack -> not configuration -> General/Unknown + Aaron in cc.
Comment 18 Bawolff (Brian Wolff) 2013-04-05 00:49:12 UTC
The hack was removed. Should verify if this is fixed.
Comment 19 Andre Klapper 2013-05-17 13:25:27 UTC
Cannot reproduce for http://de.wikipedia.org/wiki/GNOME which received an update yesterday - also correctly showing the last version when I'm logged out (in a different browser).

Is there any example or indication that this problem still exists?
Comment 20 Andre Klapper 2013-10-25 00:00:49 UTC
Is there any example or indication that this problem still exists?
Comment 21 Andre Klapper 2014-06-13 12:03:05 UTC
Closing as WORKSFORME as per comment 18 and comment 19.

Bawolff / MZ / Liangent: If you can still reproduce (because I couldn't), please reopen this ticket.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links