Last modified: 2011-06-19 17:11:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31385, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29385 - Improve, replace and/or rewrite wikidiff(2)
Improve, replace and/or rewrite wikidiff(2)
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: 5072
  Show dependency treegraph
Reported: 2011-06-13 23:03 UTC by Krinkle
Modified: 2011-06-19 17:11 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Krinkle 2011-06-13 23:03:57 UTC
Over the years there have been a few bugs and enhancement tickets regarding the diff utility we use at Wikimedia.

Opening this bug as a general tracker / reminder for this.
Comment 1 Krinkle 2011-06-13 23:05:44 UTC
From BugTriage (Third Week of 2011-06):
> JavaScript gadgets can't replace a C++ or php diff system.
>  Looking for someone to improve the native diff thing?
> Brion: Do not implement as a gadget only -- if to be done, should be done in core. If done in JS, do as a module loaded via RL.
Comment 2 Brion Vibber 2011-06-13 23:42:35 UTC
What does gnu diff3 have to do with the wikidiff extension?

diff3 is used as an internal helper tool for resolving edit conflicts; its output is either a complete merged edit (gets saved to the wiki as a new revision) or the simple report that automatic merging could not be completed, requiring the user to manually resolve the conflict.

wikidiff and wikidiff2 are C++ PHP extensions implementing 2-level paragraph-based and word-based text diff algorithm and HTML table formatting, used to produce output for the wiki's diff view UI, and compatible with the PHP implementation in MediaWiki.
Comment 3 Umherirrender 2011-06-19 16:42:40 UTC

[[de:User:PerfektesChaos]] asked me to leave a comment here.

Please have a look at his wikidiff2 improvements:


He pleased about comments.

Comment 4 Niklas Laxström 2011-06-19 16:44:57 UTC
Huh? The bug title doesn't say what is the bug or feature. Please change it.
Comment 5 Chad H. 2011-06-19 17:11:27 UTC
(In reply to comment #3)
> Hello,
> [[de:User:PerfektesChaos]] asked me to leave a comment here.
> Please have a look at his wikidiff2 improvements:
> [[mw:User:PerfektesChaos/WikidiffLX]]

Each of these suggestions should be filed as individual bugs if they aren't already (some of them look like they might already be filed).

As far as "replace wikidiff(2)" entirely...that doesn't make any sense per comment 2. If we want to expose the functionality to Javascript, that'd be an enhancement. If we want to fix specific bugs, those are concrete bugs that can be fixed. I think saying "replace the whole thing" is overkill and I'm going to go ahead and WONTFIX on those grounds.

PS: GNU diff3 is unrelated as that comment also points out.

Note You need to log in before you can comment on or make changes to this bug.