Last modified: 2012-09-27 01:10:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31307, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29307 - Line-height in <pre> is too narrow, edges overlap in some environments
Line-height in <pre> is too narrow, edges overlap in some environments
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-07 21:38 UTC by Krinkle
Modified: 2012-09-27 01:10 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
An annotated screenshot of the problem as seen in CodeReview (68.19 KB, image/png)
2011-06-07 21:38 UTC, Krinkle
Details

Description Krinkle 2011-06-07 21:38:19 UTC
Created attachment 8630 [details]
An annotated screenshot of the problem as seen in CodeReview

The line-height for pre-tags in Vector is 1.1em.

This CSS rule overrides the "line-height: 1.5em;" rule for div#bodyContent.

Attached is an annotated screenshot of a pre-tag (in this case within CodeReview). In the screenshot you can see where two lines overlap eachother.

As long as there isn't an inline background color, this is barely noticeable, and only a problem if two tall-characters are right below eachother.

But when adding background colors underscores and tall characters are chopped on the bottom.

Proposed fix: Increase line-height to 1.3em.
Comment 1 Krinkle 2011-06-07 21:43:09 UTC
Fixed in r89697.

This was also the reason the background-colouring in CodeReview was reverted (because it chopped off underscores) which was usefull for spotting whitespace changes.
Comment 2 Brion Vibber 2011-06-07 21:44:27 UTC
How do you add those overlapping borders exactly? I can't seem to reproduce any overlap as of yet (and CSS borders tend to change the actual box size, making them tough to work with for these purposes)
Comment 3 Krinkle 2011-06-07 21:47:01 UTC
I added the borders by applying CSS to <ins> and <del> in Firebug.

See also Tim's attachment in bug 27416 where the bug can be seen without borders.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links