Last modified: 2014-05-22 19:15:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31284, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29284 - Upload form should make file extensions lowercase automatically
Upload form should make file extensions lowercase automatically
Status: NEW
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch-reviewed
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-06 14:54 UTC by Vitaliy Filippov
Modified: 2014-05-22 19:15 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch for skins/common/upload.js (482 bytes, patch)
2011-06-06 14:54 UTC, Vitaliy Filippov 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Vitaliy Filippov 2011-06-06 14:54:21 UTC 
Created attachment 8627 [details]
Patch for skins/common/upload.js

IMHO upload form should make file extensions lowercase automatically during file name editbox autofill.
Patch is attached.
Comment 1 Brion Vibber 2011-06-06 17:54:05 UTC 
A few things to consider...

It looks like the name-changing in this patch is stuffed into the AJAX license preview code... it probably belongs over with fillDestFilename or other stuff that's related to the filename getting set.

When dealing with reuploading new versions over existing files, we need to make sure that the name doesn't get changed. 

Patch needs to come with test cases if possible; see tests/qunit & http://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing for more info on our new JavaScript testing framework.

Since it looks like this name transformation isn't currently applied on the PHP side either, if done here it should also be done on the PHP side. This again would need to deal with the case of existing files that violate the new recommendation.
Comment 2 johnnymrninja 2012-09-24 16:41:36 UTC 
Noting that bug 40479 would resolve this issue.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links