Last modified: 2011-11-18 01:53:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31249, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29249 - UploadWizard: add custom license wikitext option
UploadWizard: add custom license wikitext option
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Neil Kandalgaonkar
:
Depends on:
Blocks: 27800
  Show dependency treegraph
 
Reported: 2011-06-02 18:00 UTC by Neil Kandalgaonkar
Modified: 2011-11-18 01:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Neil Kandalgaonkar 2011-06-02 18:00:48 UTC
For users who want a license which is not available in the configured list, or is somehow modified by other templates, add an special option for free wikitext.

This option should itself be configurable (i.e. you can choose not to have it)
Comment 1 Neil Kandalgaonkar 2011-09-07 20:04:47 UTC
Assigning to Jeroen as it is a highly requested feature & he should be familiar with this aspect from the WLM work
Comment 2 Jeroen De Dauw 2011-09-13 18:55:13 UTC
Fixed by r96988
Comment 3 Neil Kandalgaonkar 2011-09-17 04:11:39 UTC
Unfortunately that was not really what we were after. I'm asking Jeroen to revert r96988 and I made a more explicit spec here: 

http://www.mediawiki.org/wiki/Extension:UploadWizard/CustomWikiTextLicenseFeature

And I'm trying to get community feedback here:

http://commons.wikimedia.org/wiki/Commons:Village_pump#Proposed_feature_for_UploadWizard_-_enter_license_in_custom_wikitext
Comment 4 Jeroen De Dauw 2011-09-19 15:12:21 UTC
So, can I start tackling this, or do we wait for more community feedback?
Comment 5 Neil Kandalgaonkar 2011-09-19 17:45:39 UTC
Jeroen: personally I'm no longer sure what the right implementation is. A textarea is easy, but we ought to ensure that an accepted license tag is eventually invoked by that wikitext. And I see no obvious way to do that programmatically. I thought that if there was some sort of hook that we could invoke on template transclusions, but that doesn't seem to exist, and even if it did we would only want it when parsing this special kind of wikitext... so not practical.

So, the other answer is to do an autocompletion field with items drawn from Category:License tags. That makes a lot more sense to me. And we don't have to deal with the {{self| }} variants because this is only for third party stuff anyway. I don't know if any of those License tags need arguments or if we can just invoke them by name.

What do you think?

Anyway I could wait another day or two... I only asked for feedback on Friday when most Europeans were asleep.
Comment 6 Jeroen De Dauw 2011-09-19 18:22:46 UTC
+1 for the autocompletion field. This seems the most simple and elegant solution.

> Anyway I could wait another day or two...

Sure. Please poke me when I ought to start on it then :)
Comment 8 Neil Kandalgaonkar 2011-10-31 02:07:46 UTC
I'm actually about to commit this myself. I ended up changing things a bit, it was harder than it looks.
Comment 9 Jeroen De Dauw 2011-10-31 02:39:56 UTC
Oh, cool - assigned to you then :)
Comment 10 Saibo 2011-11-17 21:34:40 UTC
file page tag:   SUBST:custom (like it is set up with {{uwl}}) please  otherwise we Commons people are not able to add e.g. date tags.
Comment 11 Saibo 2011-11-17 22:16:59 UTC
(In reply to comment #10)
Oh, but please tell me before switching it live. The template on commons needs to be adjusted for this.
Comment 12 Saibo 2011-11-18 01:10:06 UTC
{{subst:custom license marker added by UW}}   would be fine now. Prepared to be switched live at any time.
Comment 13 Neil Kandalgaonkar 2011-11-18 01:52:44 UTC
fixed in r103557. Will go live in next deploy.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links