Last modified: 2013-08-11 09:09:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.

Bug 29191 - Inconsistent user messages on too many failed logins with ConfirmEdit enabled for logins


Summary:	Inconsistent user messages on too many failed logins with ConfirmEdit enabled...

Status:	NEW

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	ConfirmEdit (CAPTCHA extension) (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-05-28 16:25 UTC by Marius Hoch
Modified:	2013-08-11 09:09 UTC (History)
CC List:	3 users (show)

See Also:	46965
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (43.89 KB, image/png) 2011-05-28 16:42 UTC, Marius Hoch	Details
Add an attachment (proposed patch, testcase, etc.)

Description Marius Hoch 2011-05-28 16:25:05 UTC

There is a slight inconsistency on user messages when trying to log in to often. If you fail several times you both get a captcha implying you should type the captcha _and_ a message saying you can't log in. ("You have made too many recent login attempts. Please wait before trying again.")

Comment 1 Marius Hoch 2011-05-28 16:42:28 UTC

Created attachment 8596 [details]
Screenshot

Comment 2 Brion Vibber 2011-05-31 20:43:18 UTC

If you wait the requisite time, do you still have to fill out the captcha? If so, then the messaging is correct.

General issue seems to be that it still offers you the login form, but tells you not to use it yet. That doesn't have anything to do with ConfirmEdit -- that's part of MediaWiki's core login handling.

Comment 3 Marius Hoch 2011-05-31 21:50:14 UTC

(In reply to comment #2)
> If you wait the requisite time, do you still have to fill out the captcha? If
> so, then the messaging is correct.
Mhm, haven't tested it that far... How long is that, btw?
> General issue seems to be that it still offers you the login form, but tells
> you not to use it yet. That doesn't have anything to do with ConfirmEdit --
> that's part of MediaWiki's core login handling.
So ConfirmEdit decides whether to show a captcha or not according to what MW does? If that's the case, "Product" should be switched to MediaWiki.

Comment 4 Brion Vibber 2011-06-06 23:43:28 UTC

When login is disabled, that has nothing to do with ConfirmEdit. That's something done by core.

Comment 5 Mark A. Hershberger 2011-06-07 02:38:03 UTC

(In reply to comment #2)
> General issue seems to be that it still offers you the login form, but tells
> you not to use it yet. That doesn't have anything to do with ConfirmEdit --
> that's part of MediaWiki's core login handling.

But then neither of the captcha or login form should be shown, right?  If the extension can allow a login when that message would be shown provided the captcha is filled out correctly, then it should also change the message or not allow it to be shown.

At least, that is what it sounds like Hoo man is saying.  Let me know if I'm confused.

Comment 6 Marius Hoch 2012-07-25 14:18:40 UTC

(In reply to comment #5)
> But then neither of the captcha or login form should be shown, right?  If the
> extension can allow a login when that message would be shown provided the
> captcha is filled out correctly, then it should also change the message or not
> allow it to be shown.
> 
> At least, that is what it sounds like Hoo man is saying.  Let me know if I'm
> confused.
Exactly, either show ONLY the message which tells you can't login or ONLY show the login form and let the user login. But showing a not disabled form which doesn't work is confusing.

Comment 7 Nemo 2013-08-10 20:57:04 UTC

(In reply to comment #2)
> If you wait the requisite time, do you still have to fill out the captcha? If
> so, then the messaging is correct.

Brion's answer was not answered but is the whole point of this bug: I've just tested myself, if you wait some time then filling the CAPTCHA is not necessary, you only have to enter the correct password; so the message is wrong.
The CAPTCHA should indeed be hidden.

The problem has been made worse by the new UserLogin because the CAPTCHA is now on top, *above* the warning about waiting some time before trying again to fill the rest of the form.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links