Last modified: 2011-06-20 23:35:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31095, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 29095 - Change Bugzilla link URL structure


Summary:	Change Bugzilla link URL structure

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Bugzilla (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Priyanka Dhanda

URL:
Whiteboard:
Keywords:	patch, patch-reviewed, shell

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-05-22 19:10 UTC by MZMcBride
Modified:	2011-06-20 23:35 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch against r88594; untested, but a simple enough change to the URL to fix links such as "[[mw:foo]]" in Bugzilla comments (567 bytes, patch) 2011-05-22 19:10 UTC, MZMcBride	Details
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2011-05-22 19:10:14 UTC

Created attachment 8565 [details]
Patch against r88594; untested, but a simple enough change to the URL to fix links such as "[[mw:foo]]" in Bugzilla comments

The URL used in the Wikimedia Bugzilla extension (<http://svn.wikimedia.org/viewvc/mediawiki/trunk/tools/bugzilla/bugzilla-4.0/extensions/Wikimedia/Extension.pm?revision=86427&view=markup>) fails with links such as "[[mw:foo]]". This is annoying.

The URL should be switched to pass through Special:Search. It should be a very simple change from "http://en.wikipedia.org/wiki/" to "http://en.wikipedia.org/w/index.php?title=Special:Search&go=Go&search=".

Patch attached against r88594. It's untested, but I don't think the "?" and "&" will do anything in this context. I'm not sure if &go=Go is strictly necessary, but it doesn't seem to hurt anything, at least.

Comment 1 Bawolff (Brian Wolff) 2011-05-23 04:05:47 UTC

bug 22407 would also fix this (and would be nice even if bugzilla was fixed to recognize the mw prefix).


Personally it seems wrong that a non-local interwiki link redirects when typed into the search box

Comment 2 MZMcBride 2011-05-23 05:05:11 UTC

(In reply to comment #1)
> bug 22407 would also fix this (and would be nice even if bugzilla was fixed to
> recognize the mw prefix).

Sure, then you can just change the broken example in this bug from "[[mw:foo]]" to "[[wmf:foo]]" or whatever.

> Personally it seems wrong that a non-local interwiki link redirects when typed
> into the search box

It seems far more wrong to return a bad title error. :-)  As long as the behavior can be adjusted to not be annoying/horrible, I think it makes sense to modify the Perl module.

Comment 3 Bawolff (Brian Wolff) 2011-05-23 06:06:37 UTC

I meant it seems wrong for mediawiki to allow such a thing. Obviously, making bugzilla work with [[mw:foo]] will be a good thing no matter how its done :)

What's the point of a local/non-local interwiki distinction if special:search will auto-redirect you regardless?

Comment 4 Mark A. Hershberger 2011-05-24 18:15:59 UTC

r88731

(I'd love to have this working soonish ;)

Comment 5 Priyanka Dhanda 2011-05-25 16:57:37 UTC

Updated on production.

Comment 6 Bawolff (Brian Wolff) 2011-06-20 23:35:39 UTC

Just wanted to quickly check something (bugzilla has no preview :( just due to weirdness in formatting my comment on bug 29406 comment 3.

[[test'd]]

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links