Last modified: 2013-06-18 13:05:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31055, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29055 - $wgEnotifUserTalk forced showing option 'minor edits notification' in Preferences
$wgEnotifUserTalk forced showing option 'minor edits notification' in Prefere...
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2011-05-19 22:55 UTC by Leinad
Modified: 2013-06-18 13:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Leinad 2011-05-19 22:55:31 UTC

'wgEnotifUserTalk' => array(
    'default' => true,

'wgEnotifMinorEdits' => array(
    'default' => false,

in this^ configuration in Special:Preferences is shown option "E-mail me also for minor edits of pages" - but if I understand correctly this configuration, this option shouldn't be shown (is useless).

Make a note that $wgEnotifMinorEdits does not affect the user's own talk page (they will be notified about all changes, regardless of this setting) - from$wgEnotifMinorEdits.
Comment 1 Leinad 2011-05-19 22:57:13 UTC
PS This applies only to projects with $wgEnotifWatchlist = false;
Comment 2 Bawolff (Brian Wolff) 2011-05-19 23:05:59 UTC
This was fixed already in r83365 (not live - part of 1.18 currently). If its really super important you might be able to convince someone to merge the change in early.

Also, I don't understand what this has to do with $wgEnotifWatchlist or why it is tagged shell.

Anyways, closing WFM (is that right resolution? it works for me on trunk, but its obviously not fixed on 'pedia, so I don't really know)
Comment 3 Leinad 2011-05-19 23:25:54 UTC
I thought there is problem with some hidden configuration.

Now I checked code from trunk... with configuration:


$wgEnotifUserTalk = true;

$wgEnotifMinorEdits = true;
$wgEnotifWatchlist = false;

and still I see option "E-mail me also for minor edits of pages" - this option I useless in this configuration, because as I wrote "$wgEnotifMinorEdits does not affect the user's own talk page" ($wgEnotifMinorEdits).
Comment 4 Leinad 2011-05-19 23:35:25 UTC
If I understand correctly, r83365 needs a little improvement:

# Doesn't make sense to have if disabled.
if ( !$wgEnotifWatchlist ) {
        $wgHiddenPrefs[] = 'enotifminoredits';
Comment 5 Bawolff (Brian Wolff) 2011-05-19 23:47:41 UTC
I think it'd make more sense to just fix the bug and make the preference work.

(Note $wgEnotifMinorEdits does have an affect on if user talk page notifications, the preference does not atm.)
Comment 6 Bawolff (Brian Wolff) 2011-05-20 04:55:13 UTC
I made the don't send on minor edits preference apply to both talk page edits, and watchlist edits in r88441.

Please feel free to re-open if its really a bad idea to do that, and just hiding it would be better.
Comment 7 Nemo 2011-09-17 00:26:24 UTC
I wonder whether it still makes sense to have the permission "Not have minor edits to discussion pages trigger the new messages prompt (nominornewtalk)" (used for bots), now that users can avoid all of them with this preference.
In general, I'm not sure it's consistent with the whole email notification system (while hiding was enough to fix the bug).

Note You need to log in before you can comment on or make changes to this bug.