Last modified: 2013-06-18 13:31:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30936, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28936 - Fix inability to remove invalid titles from watchlist (both SpecialWatchlist/edit and SpecialWatchlist/raw)
Fix inability to remove invalid titles from watchlist (both SpecialWatchlist/...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Watchlist (Other open bugs)
unspecified
All All
: High minor (vote)
: 1.19.0 release
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-11 12:48 UTC by pbugzilla
Modified: 2013-06-18 13:31 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description pbugzilla 2011-05-11 12:48:31 UTC
I have a mystery entry "HAGGER" in my watchlist. Searching the bug database I find that this relates to bug no 13602 and is probably because of reverted vandalism of some page I was watching. What that bug report doesn't say is that it seems to be impossible to get rid of the HAGGER entry in the watchlist. I have tried (several times each) using the Edit Watchlist page and the "edit the raw file" interface. In the former case, ticking the box and submitting says that HAGGER has been removed, but actually shows HAGGER still on the list. In the latter, I can remove the HAGGER line, but on pressing save, it reappears. Very odd.
Comment 1 MZMcBride 2011-05-26 01:36:45 UTC
Can you copy-paste a few lines from the raw interface to this bug? It might help with testing.
Comment 2 pbugzilla 2011-05-26 06:48:15 UTC
When you say "from the raw interface" I'm not sure quite what you mean. Here's a copy pasted bit from my Edit Watchlist page:
 (Article)
[..]
    * Homework (talk | History)
    * HАGGER? (talk)
    * Optical calcite (talk | History)
[..]

and here are the corresponding lines of HTML:

<li><input name="titles[]" type="checkbox" value="Homework" /><a href="/wiki/Homework" title="Homework">Homework</a> (<a href="/wiki/Talk:Homework" title="Talk:Homework">talk</a> | <a href="/w/index.php?title=Homework&amp;action=history" title="Homework">History</a>)</li>
<li><input name="titles[]" type="checkbox" value="HАGGER?" /><a href="/w/index.php?title=H%D0%90GGER%3F&amp;action=edit&amp;redlink=1" class="new" title="HАGGER? (page does not exist)">HАGGER?</a> (<a href="/w/index.php?title=Talk:H%D0%90GGER%3F&amp;action=edit&amp;redlink=1" class="new" title="Talk:HАGGER? (page does not exist)">talk</a>)</li>

<li><input name="titles[]" type="checkbox" value="Optical calcite" /><span class="watchlistredir"><a href="/wiki/Optical_calcite" class="mw-redirect" title="Optical calcite">Optical calcite</a></span> (<a href="/w/index.php?title=Talk:Optical_calcite&amp;action=edit&amp;redlink=1" class="new" title="Talk:Optical calcite (page does not exist)">talk</a> | <a href="/w/index.php?title=Optical_calcite&amp;action=history" title="Optical calcite">History</a>)</li>

After clicking the box next to Hagger and pressing Remove Titles, I get the following message, but no change to the actual list:

A single title was removed from your watchlist:

    * HАGGER? (talk)

Your watchlist contains 7 titles (excluding talk pages). 

Does that help at all? If not, please let me know more precisely what would help.
Comment 3 MZMcBride 2011-05-26 14:48:04 UTC
(In reply to comment #2)
> When you say "from the raw interface" I'm not sure quite what you mean. Here's
> a copy pasted bit from my Edit Watchlist page:
>  (Article)
> [..]
>     * Homework (talk | History)
>     * HАGGER? (talk)
>     * Optical calcite (talk | History)
> [..]

Sorry for the confusion. I meant from [[Special:Watchlist/raw]].

I just tried to reproduce this on test.wikipedia.org and wasn't able to, through [[Special:Watchlist/edit]] or [[Special:Watchlist/raw]]. Both allowed me to easily add or remove the title.
Comment 4 Brion Vibber 2011-06-01 19:27:29 UTC
Did a local test adding page 'HАGGER?' (with \xd0\x90) to my watchlist in raw DB and removing it through 'edit watchlist', seemed to work fine on trunk.

Conceivable that something with blacklists is breaking it somewhere along the line, but it ought not to.
Comment 5 Roan Kattouw 2011-06-01 19:30:48 UTC
(In reply to comment #2)
> href="/w/index.php?title=Talk:H%D0%90GGER%3F&amp;action=edit&amp;redlink=1"
Interesting. So this title has a character that looks like an A but isn't one, and ends in a question mark. The same issue affects now-invalid main namespace titles as WP:FOO as well; generally it should be possible to remove invalid titles from your watchlist as opposed to having them stuck forever :)

Could you (reporter) tell us what your username is and on which wiki you're seeing this mysterious HAGGER title? That'll allow me to see what your watchlist looks like in the database, which will help debugging.

Reproducing and testing this locally should be easy; just copy the bad watchlist row from Wikipedia to the local database and try to remove the watchlist entry through the UI.
Comment 6 pbugzilla 2011-06-01 19:40:31 UTC
I'm Educres on Wikipedia. On http://en.wikipedia.org/w/index.php?title=Special:Watchlist&action=raw there is not a lot to see:

[...]
Homework
HАGGER?
Optical calcite
[...]

I can apparently delete the HAGGER line, but it doesn't actually disappear. I have since remembered that I should check whether I can delete non-HAGGER lines without trouble, and indeed, I can.
Comment 7 Bawolff (Brian Wolff) 2011-06-01 19:56:42 UTC
Could you give the Hagger line from the output of http://en.wikipedia.org/w/api.php?action=query&list=watchlistraw&format=jsonfm&wrlimit=max (the api doesn't normalize watchlist titles, so it will give the actual entry)
Comment 8 pbugzilla 2011-06-01 20:55:56 UTC
{
			"ns": 0,
			"title": "H\u0410GGER?\u2002"
		},
Comment 9 pbugzilla 2011-06-01 20:57:41 UTC
oh, and further down of course
{
			"ns": 1,
			"title": "Talk:H\u0410GGER?\u2002"
		},
Comment 10 Bawolff (Brian Wolff) 2011-06-01 21:00:47 UTC
(In reply to comment #8)
> {
>             "ns": 0,
>             "title": "H\u0410GGER?\u2002"
>         },

Well that'd be the reason, since r55382 we do not allow U+2002 (which is an en-space ) to be in titles.
Comment 11 Mark A. Hershberger 2011-06-04 04:19:33 UTC
From Roan, possible steps to reproduce:

 * Create a page named "FOO:BAR" and add it to your watchlist
 * change your localsettings.php to register a namespace alias from "FOO" to, say, NS_PROJECT
 * have fun trying to remove FOO:BAR from the watchlist.
Comment 12 MZMcBride 2011-06-04 05:37:24 UTC
(In reply to comment #11)
> From Roan, possible steps to reproduce:
> 
>  * Create a page named "FOO:BAR" and add it to your watchlist
>  * change your localsettings.php to register a namespace alias from "FOO" to,
> say, NS_PROJECT
>  * have fun trying to remove FOO:BAR from the watchlist.

Your reply strongly indicates that you didn't read the previous comments on this bug. This bug isn't about namespace aliases and watchlists. Those issues are covered by bug 24280 and bug 5280. A similar (or the same) solution might be possible for namespace aliases and other invalid characters (such as \u2002), but this bug specifically is about invalid characters causing irremovable entries on a watchlist.
Comment 13 Mark A. Hershberger 2012-01-23 15:46:31 UTC
switch to milestone, remove release tracking dep
Comment 14 Max Semenik 2012-02-09 20:40:14 UTC
Fixed in r111085.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links