Last modified: 2013-11-04 07:24:05 UTC
On 5/9/11 6:17 PM, Erik Moeller wrote: > - Tester "Egessaman" ran into a problem when she used the same title > twice. This was not detected, and so one of her files failed in the > final step, with no possibility of correction. N.b. this problem could be encountered by users whenever anybody uploads a file with the same title after the last time they did their own title-uniqueness check. So we have to be ready for it generally, not just within multiple-file uploads. Generally this should have been a FileRenameError; uncertain why it was not caught.
The most confusing thing here is that after confirming the upload + description you're told there's already a file with that title but you can only retry (which will always fail) or abort the upload of that file, with no possibility of going back, so all the work on description gets lost.
Matthew, one of the Wikimedia storytellers, just brought this to my attention as well. Regardless of what else is done, it'd be good to extend the in-page title uniqueness check to examine the other titles in the current upload. It's actually kinda funny that it checks for already-used titles in a remote database, but doesn't do this much simpler thing. :)
Created attachment 8813 [details] Screenshot of current behavior An error should be displayed at this point, probably above the title I'm currently editing.
By the way, I tried it again and if you abort but click the button to upload more (can't remember the name) the aborted file will be automatically selected for upload (but nothing else).
Current behavior is to not detect it, and upload *both* files with the same name. This may be desired in a few use cases (eg. uploading at the same time the original image plus an improved one), but in most cases the user will be uploading a set of different (albeit related) images, and giving the same name to both photos a mistake. It can be fixed by an admin, but it's not simple: delete, restore, move, recreate, restore.
Created attachment 9438 [details] .. and the result if you try to publish them. I ran in this error too. Another way would be automatically appending random numbers to the file-title.
*** Bug 31208 has been marked as a duplicate of this bug. ***
This should have been fixed -- we are getting a dialog box when we try to upload the same file twice -- but instead, the file is getting added, anyway, with an empty filename. This bug is in production. Marking high priority.
Assigning to Ian because I believe he was the one who originally fixed this.
Er, I think I modified the wrong bug. This is about the desired titles in the Details step. Sorry. Downgrading.
This is what was happening in Bug 32843, could someone mark as duplicate? Also, for anyone interested: https://gerrit.wikimedia.org/r/7149 is the fix.
*** This bug has been marked as a duplicate of bug 32843 ***
