Last modified: 2013-06-18 14:44:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 28863 - Remove references to code deprecated before 1.17 in 1.18
Remove references to code deprecated before 1.17 in 1.18
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 24711
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2011-05-06 23:14 UTC by Sam Reed (reedy)
Modified: 2013-06-18 14:44 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-05-06 23:14:14 UTC
$wgAllowUserSkin/$wgAllowRealName/$wgExtensionAliasesFiles/$wgExtraRandompageSQL

Linker::tooltip() (from 1.14!)

since 1.16. Most are calling each other, so can be generally cleaned up
Linker::makeBrokenLink()
Linker::makeLinkObj()
Linker::makeKnownLinkObj()
Linker::makeBrokenLinkObj()
Linker::makeColouredLinkObj()
Linker::makeImageLinkObj()

LogReader and LogViewer but that's bug 24711


Seems the Linker ones are the bigger issues...
Comment 1 Sam Reed (reedy) 2011-05-06 23:25:38 UTC
$wgExtensionAliasesFiles is another
Comment 2 Sam Reed (reedy) 2011-05-06 23:31:23 UTC
makeBrokenLink is called by Interlanguage Extension

makeLinkObj is called by AjaxShowEditors, FCKeditor and SemanticForms

makeKnownLinkObj is called by SemanticForms (x2) and in Linker::makeColouredLinkObj

makeBrokenLinkObj is called by Linker::makeBrokenLink

makeColouredLinkObj is called by Linker::makeColouredLinkObj (deprecated in 1.17)

makeImageLinkObj killed
Comment 3 Chad H. 2011-05-08 02:41:05 UTC
(In reply to comment #1)
> $wgExtensionAliasesFiles is another

I think we should keep that around a little bit longer so extensions don't break back-compat. Maybe next release.
Comment 4 Mark A. Hershberger 2011-06-16 16:53:46 UTC
It should be fine to start removing the code for 1.18
Comment 5 Mark A. Hershberger 2011-08-04 01:01:34 UTC
moving to low priority since we're not desperate to get this done.
Comment 6 Rob Lanphier 2011-08-10 20:20:05 UTC
Not a 1.18 blocker, and one that we shouldn't do for the sake of doing.  If there's a feature that we're working on that breaks these, then we can remove them as part of that work, but we shouldn't break backwards compatibility just for giggles.
Comment 7 Chad H. 2011-08-10 20:28:35 UTC
(In reply to comment #6)
> Not a 1.18 blocker, and one that we shouldn't do for the sake of doing.  If
> there's a feature that we're working on that breaks these, then we can remove
> them as part of that work, but we shouldn't break backwards compatibility just
> for giggles.

Well stuff that's already marked for deprecation can be slowly phased out once extensions have all been updated (and then the general consensus is to wait at least one more release). When we mark stuff @deprecated these days we generally mention when they were first deprecated so we can properly remove them over time.

But yes, removing deprecated code shouldn't be a blocker unless it's breaking something by remaining there.
Comment 8 Mark A. Hershberger 2011-12-20 21:08:58 UTC
Changing default assignee per IRC
Comment 9 Sam Reed (reedy) 2012-04-11 23:16:11 UTC
No real reason for this to explicitly stay open

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links