Last modified: 2012-05-03 02:42:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 28643 - Merge Serbian language variant conversion improvements to trunk
Merge Serbian language variant conversion improvements to trunk
Product: MediaWiki
Classification: Unclassified
Language converter (Other open bugs)
All All
: Normal normal (vote)
: 1.19.0 release
Assigned To: Antoine "hashar" Musso (WMF)
Depends on:
Blocks: 31217
  Show dependency treegraph
Reported: 2011-04-21 13:40 UTC by Nikola Smolenski
Modified: 2012-05-03 02:42 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Nikola Smolenski 2011-04-21 13:40:04 UTC
In my MediaWiki branch (files and ) I have introduced changes which tell MediaWiki not to convert Serbian text between variants if the conversion is not necessary (i.e. it won't convert Cyrillic to Cyrillic, or Latin to Latin). This should drastically reduce the need for -{}- tags, that users generally underuse. Please merge this to trunk, so that it may be deployed to Wikimedia projects. Nikerabbit seems to approve (see comments at ) and LanguageConverter maintainers seem to have no problems with it.
Comment 1 Roan Kattouw 2011-04-21 13:44:28 UTC
Is it just r85224 and its followup r85239 that need merging?
Comment 2 Chad H. 2011-04-21 13:48:12 UTC
And r85308, with the comment fix.
Comment 3 Chad H. 2011-04-21 14:03:17 UTC
Merged in r86623
Comment 4 Nikola Smolenski 2011-08-31 14:47:29 UTC
Reopened since it got reverted in r90951. I will try to write the tests.
Comment 5 Antoine "hashar" Musso (WMF) 2011-10-24 10:55:46 UTC
Nikola  > have you made any progress on writing tests? I can write them for you if you can explain me what is the expected behavior :-)
Comment 6 Antoine "hashar" Musso (WMF) 2011-10-31 17:34:45 UTC
Tests added in Nikola branch: r101369 . I have emailed him so he can review the tests and eventually add more.
Comment 7 Nikola Smolenski 2011-11-15 06:22:27 UTC
Thank you so much hashar :) The tests test what they are supposed to test, and I have added one more (roman numerals) in r103131.
Comment 8 Antoine "hashar" Musso (WMF) 2011-11-15 22:24:37 UTC
Thanks to have taken sometime to review the tests. It is probably safer when a native speaker handle that sort of language issues. Kudos on the test addition!

I will merge the branch in trunk :-)
Comment 9 Antoine "hashar" Musso (WMF) 2011-11-16 15:12:59 UTC
LanguageSr improvement in /branches/nikola/phase3 got merged by r103327

It is too late for inclusion in 1.18 but will surely be able to deploy this on the live site with 1.19.

Note You need to log in before you can comment on or make changes to this bug.