Last modified: 2012-05-03 02:42:44 UTC
In my MediaWiki branch (files http://svn.mediawiki.org/viewvc/mediawiki/branches/nikola/phase3/languages/LanguageConverter.php and http://svn.mediawiki.org/viewvc/mediawiki/branches/nikola/phase3/languages/classes/LanguageSr.php ) I have introduced changes which tell MediaWiki not to convert Serbian text between variants if the conversion is not necessary (i.e. it won't convert Cyrillic to Cyrillic, or Latin to Latin). This should drastically reduce the need for -{}- tags, that users generally underuse. Please merge this to trunk, so that it may be deployed to Wikimedia projects. Nikerabbit seems to approve (see comments at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85224#code-comments ) and LanguageConverter maintainers seem to have no problems with it.
Is it just r85224 and its followup r85239 that need merging?
And r85308, with the comment fix.
Merged in r86623
Reopened since it got reverted in r90951. I will try to write the tests.
Nikola > have you made any progress on writing tests? I can write them for you if you can explain me what is the expected behavior :-)
Tests added in Nikola branch: r101369 . I have emailed him so he can review the tests and eventually add more.
Thank you so much hashar :) The tests test what they are supposed to test, and I have added one more (roman numerals) in r103131.
Thanks to have taken sometime to review the tests. It is probably safer when a native speaker handle that sort of language issues. Kudos on the test addition! I will merge the branch in trunk :-)
LanguageSr improvement in /branches/nikola/phase3 got merged by r103327 It is too late for inclusion in 1.18 but will surely be able to deploy this on the live site with 1.19.
