Last modified: 2011-10-03 05:10:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29889, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 27889 - Tidy fails silently if missing, documentation out of date


Summary:	Tidy fails silently if missing, documentation out of date

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Parser (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Normal critical with 1 vote (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://translatewiki.net/w/i.php?titl...
Whiteboard:
Keywords:

Depends on:
Blocks:	tidy
	Show dependency tree / graph

Reported:	2011-03-06 10:29 UTC by Niklas Laxström
Modified:	2011-10-03 05:10 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2011-03-06 10:29:42 UTC

The following input is not fixed and causes page layout to explode:

 <big><big><big>ܫܠܡܐ ܘܐܝܩܪܐ
<big><big>Hello!
 <big><big>اهلا وسهلا

In the source code it reads:
<!-- Tidy found serious XHTML errors -->

Comment 1 Siebrand Mazeland 2011-03-06 11:25:31 UTC

URL updated.

Comment 2 Niklas Laxström 2011-03-06 11:28:56 UTC

Not a regression. Started happening after we moved to a newer server with newer PHP.

Comment 3 Platonides 2011-03-06 15:34:18 UTC

Works for me with external tidy, version 25 March 2009.

Can be tested with:
<?php
/* Bug 27889 */
require_once( "maintenance/commandLine.inc" );
echo MWTidy::tidy("<big><big><big>ܫܠܡܐ ܘܐܝܩܪܐ
<big><big>Hello!
 <big><big>اهلا وسهلا");

I get
<p><big><big><big>ܫܠܡܐ ܘܐܝܩܪܐ <big><big>Hello! <big><big>اهلا وسهلا</big></big></big></big></big></big></big></p>

Comment 4 Niklas Laxström 2011-03-06 16:01:11 UTC

Meeh. MediaWiki doesn't warn if tidy isn't installed.

Comment 5 Sam Reed (reedy) 2011-03-06 16:01:47 UTC

(In reply to comment #4)
> Meeh. MediaWiki doesn't warn if tidy isn't installed.

That sounds like a bug..

Comment 6 Platonides 2011-03-06 16:06:32 UTC

If you didn't have Tidy, where did 'Tidy found serious XHTML errors' message came from?

Comment 7 Niklas Laxström 2011-03-06 16:09:43 UTC

Now when I installed libtidy and the PHP module with pecl install tidy (not with *pear* as it says everyhere) I get:

Fatal error: Class 'tidy' not found in /www/sandwiki/includes/parser/Tidy.php on line 195

Comment 8 Niklas Laxström 2011-03-06 16:14:42 UTC

Okay, the PECL is for PHP 4.x only. tidy is now bundled with PHP5 and I can't find any in PEAR. Documentation needs also updating.

Comment 9 Aaron Schulz 2011-09-27 17:22:16 UTC

(In reply to comment #8)
> Okay, the PECL is for PHP 4.x only. tidy is now bundled with PHP5 and I can't
> find any in PEAR. Documentation needs also updating.

What still needs updating?

Comment 10 Niklas Laxström 2011-09-28 15:11:58 UTC

Docs how to install tidy, and have MW complain instead of failing silently?

Comment 11 Aaron Schulz 2011-09-28 15:20:45 UTC

There were some changes back in r92106.

Comment 12 Aaron Schulz 2011-09-28 15:32:30 UTC

(In reply to comment #10)
> Docs how to install tidy, and have MW complain instead of failing silently?

MW.org? Manual:$wgTidyInternal and Manual:$wgTidy seem OK now.

Comment 13 Niklas Laxström 2011-10-03 03:39:40 UTC

If you think it's fixed, please close this bug. I'm not going to build an environment without tidy to test this.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links