Last modified: 2011-05-04 20:02:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29532, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27532 - Bug in mw.loader JS
Bug in mw.loader JS
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: High minor (vote)
: ---
Assigned To: Krinkle
:
: 27970 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-18 13:01 UTC by Bergi
Modified: 2011-05-04 20:02 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bergi 2011-02-18 13:01:19 UTC
The input validating of mw.loader.load (line 995) makes no sense.

> 996	// Validate input
> 997	if ( typeof modules !== 'object' && typeof modules !== 'string' ) {
> 998		throw new Error( 'dependencies must be a string or an array, not a ' +
> 999		typeof dependencies )
> 1000	}

I'd guess it should be "modules" instead of "dependencies".
Comment 1 Krinkle 2011-02-18 22:15:15 UTC
it also doesn't seem to check suspended in mw.load
Comment 2 Krinkle 2011-03-10 17:29:58 UTC
*** Bug 27970 has been marked as a duplicate of this bug. ***
Comment 3 Krinkle 2011-03-10 17:30:45 UTC
(Chad H. wrote at bug 27970 comment #1)
> Fixed in r83649.
Comment 4 Krinkle 2011-03-10 22:56:12 UTC
Reopening as the suspended state (triggered by mw.loader.go() ) is still not checked.

It should be an easy fix but I feel like there may be a catch. I'll run some tests and if OK just add a simple if()-statement.
Comment 5 Krinkle 2011-05-04 20:02:15 UTC
Looks like suspended is checked fine, it's checked in .loader.work, which is called from request(), which is called from mw.loader.load.

Marking as fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links