Last modified: 2014-09-24 00:50:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 27158 - Adjust datetime in email confirmation email
Adjust datetime in email confirmation email
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Email (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Tony Thomas
:
Depends on:
Blocks: 1932
  Show dependency treegraph
 
Reported: 2011-02-04 19:35 UTC by Umherirrender
Modified: 2014-09-24 00:50 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2011-02-04 19:35:28 UTC
My account creation time on release-de-wiki is 3. February 2011, 21:28, but the confirmation code will expire at 10. February 2011, *20*:28. Looks like UTC, because timezone of that wiki is +01:00.

I have seen, that in r32557 the date format was changed from content language to userlanguage, but the time adjust was not removed, and so the time in the e-mail is UTC, I think.

Thanks.
Comment 1 Brion Vibber 2011-02-05 00:27:17 UTC
User::sendConfirmationMail() fills this out; it's currently disabling timezone adjustment on the output.

Should double-check if $wgUser is always correct here (what about when an existing logged-in user creates someone else's account?) -- if it's safe, then can just pass true to let the user/default settings be used. Otherwise, need to pull the setting from the user and pass it in direct as fourth parameter to timeanddate() etc.
Comment 2 Gerrit Notification Bot 2014-03-21 06:15:53 UTC
Change 119936 had a related patch set uploaded by 01tonythomas:
Adjust datetime in email confirmation email

https://gerrit.wikimedia.org/r/119936
Comment 3 Krinkle 2014-06-21 12:17:32 UTC
(In reply to Brion Vibber from comment #1)
> User::sendConfirmationMail() fills this out; it's currently disabling
> timezone adjustment on the output.
> 
> Should double-check if $wgUser is always correct here (what about when an
> existing logged-in user creates someone else's account?) -- if it's safe,
> then can just pass true to let the user/default settings be used. Otherwise,
> need to pull the setting from the user and pass it in direct as fourth
> parameter to timeanddate() etc.

Yeah, the method change I58b2f6a0a37d modifies doesn't seem to be tied to the global wgUser in any way so it should either use the wiki standard timezone or the target user, not the global user.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links