Last modified: 2011-02-02 22:11:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29042, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 27042 - Update any calls of deprecated (and the method calls wfDeprecated()) methods in phase3 pre 1.17 branch
Update any calls of deprecated (and the method calls wfDeprecated()) methods ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-30 08:24 UTC by Sam Reed (reedy)
Modified: 2011-02-02 22:11 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-01-30 08:24:40 UTC 
Like bug 27041 (I'm not sure if there will be any), check for, and if any exist, update callers of methods that call wfDeprecated(), so 1.17 doesn't start throwing deprecated warnings at the top of every page for the release and WMF updates
Comment 1 Sam Reed (reedy) 2011-01-30 08:31:23 UTC 
http://toolserver.org/~krinkle/wikimedia-svn-search/do-live.php?path=%2Ftrunk%2Fphase3&recursive=on&searchphrase=wfDeprecated&timestamp=1296376151

All the wfDeprecated() calls in phase3, seems to be 39 methods that need exploring/checking for this and bug 27041
Comment 2 Sam Reed (reedy) 2011-01-30 17:03:38 UTC 
Database->escapeLike - 1 in phase3, 1 in tools

Being kicked off my computer, my little sister wants to play games ;) Will carry on later
Comment 3 Sam Reed (reedy) 2011-01-30 18:31:16 UTC 
And that concludes the list. Obviously, this doesn't include any called via vodoo, or other unobvious ways, but gives us a reasonable idea of what's going on.

Might have missed a couple in phase3...

A couple of them will be only warning in 1.18, so that needs paying attention to, but if it was set to start warning in 1.17, they need tidying up. (I know some people do tidy them up when they mark them as deprecated with a warning)
Comment 4 Sam Reed (reedy) 2011-01-30 22:14:23 UTC 
Taken care of the phase3 one in r81215, and the tools one in r81216

Leaving the bug open for the moment
Comment 5 Mark A. Hershberger 2011-02-02 19:52:11 UTC 
Having deprecated calls in doesn't really block anything.
Comment 6 Sam Reed (reedy) 2011-02-02 22:11:05 UTC 
Marking RESOLVED FIXED as I look to have tidied everything up in core, and marked for backport where appropriate
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links