Last modified: 2014-11-17 10:36:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28914, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26914 - Bundle WikiEditor extension with MediaWiki
Bundle WikiEditor extension with MediaWiki
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement with 2 votes (vote)
: 1.18.0 release
Assigned To: Nobody - You can work on this!
:
Depends on: 26918
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-24 23:02 UTC by Ryan Kaldari
Modified: 2014-11-17 10:36 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2011-01-24 23:02:00 UTC
Once a few remaining issues are resolved, the new WikiEditor developed as part of the Usability Initiative should be folded into the MediaWiki core to replace the old "monobook toolbar".
Comment 1 Krinkle 2011-01-24 23:11:30 UTC
See also 26750 comment 3 and further down.
Comment 2 Krinkle 2011-01-24 23:11:41 UTC
bug 26750 comment 3 *
Comment 3 MZMcBride 2011-01-25 00:16:35 UTC
WikiEditor was moved from /trunk/extensions/UsabilityInitiative/WikiEditor to /trunk/extensions/WikiEditor (making it its own extension) in r73054.

There is a large debate in the code comments of r73030 (where Vector was moved from /trunk/extensions/UsabilityInitiative/Vector to /trunk/extensions/Vector) regarding whether keeping some of this functionality in extensions is a good idea. There's additional discussion on the wikitech-l mailing list: http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/50223

There seem to be divergent theories about how much code/functionality should be in MediaWiki core and how much code/functionality should be in extensions.

All of this is said without re-expressing my opinion on this issue, but whoever tries to resolve this bug should be warned that doing so may have unexpected consequences.
Comment 4 Brion Vibber 2011-01-25 00:20:16 UTC
Broadly speaking I would recommend:

1) keep WikiEditor as an extension
2) migrate the *old* toolbar to an extension too (leaving just a plain textarea as the extensionless version)
3) ship WikiEditor extension on by default with MediaWiki
4) make sure there's a fairly clean interface for plugging in other alternate editor frontends
Comment 5 Trevor Parscal 2011-01-25 00:30:37 UTC
Yes, yes and yes! +1
Comment 6 Ryan Kaldari 2011-01-25 01:17:41 UTC
I really have no strong opinion on this. I just created this bug to keep Bug 26750 from getting derailed. Feel free to close as WONTFIX if it does not appear there is consensus for this.
Comment 7 Krinkle 2011-01-25 01:34:49 UTC
(In reply to comment #4)
> Broadly speaking I would recommend:
> 
> 1) keep WikiEditor as an extension
> 2) migrate the *old* toolbar to an extension too (leaving just a plain textarea
> as the extensionless version)
> 3) ship WikiEditor extension on by default with MediaWiki
> 4) make sure there's a fairly clean interface for plugging in other alternate
> editor frontends

Sounds good to me.

Created bug 26918 for point 4 by the way.
Comment 8 Mark A. Hershberger 2011-01-27 20:08:34 UTC
updated summary.  Now, to create that clean interface.
Comment 9 Krinkle 2011-05-06 18:12:18 UTC
* Removing blockage to bug 26751 ("Extensions that should really be core functionality"), since we're probably going to bundle this by using the new installer.

* Adding dependancy on bug 26918
Comment 10 Bugmeister Bot 2011-08-19 19:12:56 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 11 moejoe0000 2012-01-15 16:34:47 UTC
I post here because it is for me much related:

I was just installing WikiEditor bundled with MediaWiki tarball and activating the extension in the installer. Unfortunately, this does not help much because WikiEditor is by default disabled which requires to modify LocalSettings.php manually.

At a first place this may be confusing as the installer claims that checking the checkbox is sufficient.

Before bundeling one had to download WikiEditor seperately which forced the user to read [[mw:Extension:WikiEditor]] where the (correct) installation process is explained. Now nobody forces the user to read that anymore. 

Would is not be rasonable also to enable WikiEditor if somebody tells the installer that it shall be installed? (Maybe changing the defaults of WikiEditor?)
Comment 12 Sam Reed (reedy) 2012-01-15 16:36:34 UTC
Marking fixed as the actual bug is...
Comment 13 Sam Reed (reedy) 2012-01-15 16:37:31 UTC
(In reply to comment #11)
> I post here because it is for me much related:
> 
> I was just installing WikiEditor bundled with MediaWiki tarball and activating
> the extension in the installer. Unfortunately, this does not help much because
> WikiEditor is by default disabled which requires to modify LocalSettings.php
> manually.
> 
> At a first place this may be confusing as the installer claims that checking
> the checkbox is sufficient.
> 
> Before bundeling one had to download WikiEditor seperately which forced the
> user to read [[mw:Extension:WikiEditor]] where the (correct) installation
> process is explained. Now nobody forces the user to read that anymore. 
> 
> Would is not be rasonable also to enable WikiEditor if somebody tells the
> installer that it shall be installed? (Maybe changing the defaults of
> WikiEditor?)

See also bug 31279

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links