Last modified: 2012-09-27 01:10:42 UTC
The renderNavigation and renderPortals functions in Vector contain all kinds of useful stuff that a developer should be able to override in a sub class.
This sort of comment really belongs in CodeReview. See r53210 where I've made just this comment (prompted by this bug).
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Created attachment 9867 [details]
Change private functions in Vector.php to protected
(In reply to comment #1)
> This sort of comment really belongs in CodeReview. See r53210 where I've made
> just this comment (prompted by this bug).
Thanks, I'll do that next time. If I knew Trevor's email address, I would probably add him to the cc list too so he would see this bug report.
That said, the average person submitting a bug is not going to hunt down the annotated code file to determine who first made a change and then hunt down the code review page to comment on it.
Christian, thanks for the patch. I've added the keywords "need-review" and "patch" so the bug shows up in the lists of patches awaiting review for committing or critique.