Last modified: 2011-05-13 09:37:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 25653 - FCKeditor doesn't work in the latest version of MW with any RTL installation
FCKeditor doesn't work in the latest version of MW with any RTL installation
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FCKeditor (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
http://wikidemo.willki.com/heb16
: i18n, patch, patch-reviewed
: 25534 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-10-26 12:41 UTC by gregory
Modified: 2011-05-13 09:37 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch to the latest r78294 based on text in the ticket (946 bytes, patch)
2010-12-13 12:34 UTC, Jeroen Ruigrok van der Werven 		Details
Add an attachment (proposed patch, testcase, etc.)

Description gregory 2010-10-26 12:41:11 UTC 
There seems to be a JavaScript problem with this version that concerns the localization to Hebrew (and maybe other languages too). When I change $wgLanguageCode to En, it works perfectly but as soon as I change back to Hebrew the editor couldn't load. I also get on my firebug these JS errors:

<pre>
 unterminated string literal
 ss/fckeditor-rtl.css";\n

 showFCKEditor is not defined
 if( showFCKEditor & ( RTE_POPUP|RTE_TOGGLE_LINK ) ){ 
</pre>

To see the bug, go to my wiki (as I mentioned in the URL) - and <a href='http://wikidemo.willki.com/heb16/index.php?title=%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99&action=edit'>edit</a>.
Comment 1 gregory 2010-11-15 03:01:39 UTC 
(In reply to comment #0)
> There seems to be a JavaScript problem with this version that concerns the
> localization to Hebrew (and maybe other languages too). When I change
> $wgLanguageCode to En, it works perfectly but as soon as I change back to
> Hebrew the editor couldn't load. I also get on my firebug these JS errors:
> 
> <pre>
>  unterminated string literal
>  ss/fckeditor-rtl.css";\n
> 
>  showFCKEditor is not defined
>  if( showFCKEditor & ( RTE_POPUP|RTE_TOGGLE_LINK ) ){ 
> </pre>
> 
> To see the bug, go to my wiki (as I mentioned in the URL) - and <a
> href='http://wikidemo.willki.com/heb16/index.php?title=%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99&action=edit'>edit</a>.

OK, got it working.
One of the JS lines was buggy.
To fix it, change line 418 in extensions/FCKeditor/FCKeditor.body.php from

 $script .= 'oFCKeditor.Config["EditorAreaCSS"] = wgScriptPath + "/" + wgFCKEditorExtDir + "/css/fckeditor.css, wgScriptPath + "/" + wgFCKEditorExtDir + "/css/fckeditor-rtl.css";';

to

$script .= 'oFCKeditor.Config["EditorAreaCSS"] = wgScriptPath + "/" + wgFCKEditorExtDir + "/css/fckeditor.css" + wgScriptPath + "/" + wgFCKEditorExtDir + "/css/fckeditor-rtl.css";';
Comment 2 Jeroen Ruigrok van der Werven 2010-12-13 12:29:51 UTC 
*** Bug 25534 has been marked as a duplicate of this bug. ***
Comment 3 Jeroen Ruigrok van der Werven 2010-12-13 12:31:11 UTC 
This is not in the repository yet, so do not mark it as resolved fixed.
Comment 4 Jeroen Ruigrok van der Werven 2010-12-13 12:34:38 UTC 
Created attachment 7904 [details]
Patch to the latest r78294 based on text in the ticket
Comment 5 Mark A. Hershberger 2011-02-14 21:16:00 UTC 
See r82145
Comment 6 Gustavo Schlaien 2011-03-07 11:18:00 UTC 
Just amazing, worked like a charm!!!! Thanks Gregory
Comment 7 Gadi Cohen 2011-05-12 00:12:16 UTC 
The above patch does not properly fix the problem.

Although it solves the 'unterminated string' error, the changed line is still incorrect.  The result is that although FCKeditor will now 'load', the style sheets are still not loaded and style formatting is absent from the editor.

I've created a diff against the diff above that properly solves the problem.
r69707_and_trunk-r87608.29_SOLVED">http://www.mediawiki.org/wiki/Extension_talk:FCKeditor_(Official)#Extension_doesn.27t_work_with_RTL_languages_.28exists_in_1.16-r69707_and_trunk-r87608.29_SOLVED

In short, there needs to be a commma between the location of the two style sheets.
Comment 8 p858snake 2011-05-12 00:45:34 UTC 
de-blocking from 26676, this is a extension so its not blocking the 1.17 release.
Comment 9 p858snake 2011-05-12 00:50:21 UTC 
-need-review +reviewd. patch has been applied.
Comment 10 Mark A. Hershberger 2011-05-12 23:09:16 UTC 
(In reply to comment #9)
> -need-review +reviewd. patch has been applied.

Could you post the revision number and re-close the bug?
Comment 11 p858snake 2011-05-12 23:50:28 UTC 
(In reply to comment #10)
> (In reply to comment #9)
> > -need-review +reviewd. patch has been applied.
> 
> Could you post the revision number and re-close the bug?

(In reply to comment #5)
> See r82145

its been reopened since then, so no i'm not closing.
Comment 12 Mark A. Hershberger 2011-05-13 09:37:21 UTC 
(In reply to comment #7) 
> In short, there needs to be a commma between the location of the two style
> sheets.

And the quotes need to be closed.  Who was the idiot who did that?

(In reply to comment #5)
> See r82145

Oh.  /me tries to hide himself.

r87957
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links