Last modified: 2014-07-11 10:00:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27482, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25482 - Merge RenameUser into core
Merge RenameUser into core
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Renameuser (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/Extensi...
:
Depends on:
Blocks: 26751
  Show dependency treegraph
 
Reported: 2010-10-10 19:11 UTC by Sam Reed (reedy)
Modified: 2014-07-11 10:00 UTC (History)
15 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2010-10-10 19:11:20 UTC
It really should be core functionality...
Comment 1 Quim Gil 2013-03-05 19:13:19 UTC
This extensions was bundled (by you)  :) and it sits now under "Closed" at http://www.mediawiki.org/wiki/List_of_extensions_to_be_merged_to_the_core#Renameuser

There hasn't been any progress here since 2010. Should we resolve this as WONTFIX?
Comment 2 Andre Klapper 2013-04-25 11:42:40 UTC
Reedy: Could you answer comment 1, please?
Comment 3 James Forrester 2013-05-08 22:06:12 UTC
(In reply to comment #1)
> This extensions was bundled (by you)  :) and it sits now under "Closed" at
> http://www.mediawiki.org/wiki/
> List_of_extensions_to_be_merged_to_the_core#Renameuser
> 
> There hasn't been any progress here since 2010. Should we resolve this as
> WONTFIX?

I think we should do this, rather than just bundling the extension; it's what people will expect of administrator toolsets nowadays.
Comment 4 Andre Klapper 2013-05-14 09:52:35 UTC
(In reply to comment #3)
> > There hasn't been any progress here since 2010. Should we resolve this as
> > WONTFIX?
> 
> I think we should do this, rather than just bundling the extension; it's what
> people will expect of administrator toolsets nowadays.

Closing. Please reopen if you disagree.
Comment 5 Matthew Flaschen 2013-05-14 19:03:29 UTC
I think by "we should do this", James meant "we should merge it into core".
Comment 6 James Forrester 2013-05-14 20:15:11 UTC
Agreed; this is something we should merge.

CC'ing Chris who would be most likely the one responsible. (Sorry, Chris. :-))
Comment 7 MZMcBride 2013-05-14 23:37:50 UTC
It'd be awfully nice to clean up the database schema before doing this, but it's not strictly a blocker.
Comment 8 p858snake 2013-05-15 03:14:35 UTC
Please give a deeper elaboration reason other than "we should" when we already have bundled in the installer.
Comment 9 James Forrester 2013-05-15 03:20:17 UTC
(In reply to comment #8)
> Please give a deeper elaboration reason other than "we should" when we
> already have bundled in the installer.

See comment 3.

"[W]e already have bundled in the installer" means that *some* people (who use the tarballs, which is far from all our downstream users) will probably, hopefully have it available. That's not sufficient for what is an expected piece of fundamental account management (for anti-vandalism purposes, account management and others).
Comment 10 p858snake 2013-05-15 04:13:49 UTC
(In reply to comment #9)
> ...snip...
> "[W]e already have bundled in the installer" means that *some* people (who
> use
> the tarballs, which is far from all our downstream users) 

basically its most people apart from

A. Directly setup from out VCS (I'm sure they can manage installing a extension)
B. People who install from OS-Packages (Which afaik we don't really support anyway, And could bundle the extensions into a seperate package file like they used to do for maths supportor they could probably still do it normally in the installer )
C. CPanel/Fantastio/etc users

There has been numerous discussions on the lists and IRC channels about Bundling in Core vs Bundling ext in the installer package, And I haven't really be swayed away from the latter yet in-regards to the bigger picture.
Comment 11 Matthew Flaschen 2013-05-15 04:16:46 UTC
(In reply to comment #10)
> There has been numerous discussions on the lists and IRC channels about
> Bundling in Core vs Bundling ext in the installer package, And I haven't
> really
> be swayed away from the latter yet in-regards to the bigger picture.

Indeed, there's been a fair amount of talk about it.  But I don't think there's one fixed rule, like "Always/Never make it an extension if you can".

It depends on how, well, core, the functionality is.  If it's something every wiki, or almost every wiki, needs, that's an argument to move it to core.  Doing so can sometimes allow structuring the code in a simpler way.
Comment 12 Nathan Larson 2014-07-11 04:08:05 UTC
I agree, it should be merged into core. Would a patch to accomplish that be accepted?
Comment 13 Kunal Mehta (Legoktm) 2014-07-11 10:00:35 UTC
(In reply to Nathan Larson from comment #12)
> I agree, it should be merged into core. Would a patch to accomplish that be
> accepted?

If it's just the current code in the extension, I would say no. I do agree that renameuser-functionality should be in core though.

Special:Renameuser's code is a mess, and should be re-written with FormSpecialPage. The logic should also be abstracted into its own class so make adding an API module trivial.

Also it doesn't support shared user tables, which would be a blocker IMO (though, that would probably just work if bug 31863 was fixed).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links