Last modified: 2010-05-15 15:37:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4532, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 2532 - Image filenames in the form 123px-Something.jpg cause problems to thumbnails of both Something.jpg and 123px-Something.jpg
Image filenames in the form 123px-Something.jpg cause problems to thumbnails ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.5.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/wiki/Cat...
:
: 2763 3055 3457 4722 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-26 13:58 UTC by Tim Starling
Modified: 2010-05-15 15:37 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tim Starling 2005-06-26 13:58:11 UTC
Images can be uploaded in the form 123px-Something.jpg. This clashes with the
new structure of the thumbnail directory in 1.5. If a thumbnail of
123px-Something.jpg is requested, the script attempts to create a directory
called 123px-Something.jpg, but that name may already be taken by an actual
thumbnail image left after 1.4 conversion. Thus, warnings and broken thumbnail
links are issued on render.
Comment 1 Tim Starling 2005-06-26 14:12:28 UTC
Really it's only a conversion issue, the problem can be solved by moving all
offending images to the new structure. 
Comment 2 Tomer Chachamu 2005-07-03 16:49:41 UTC
I am currently loading the DB dump of en: into a MySQL installation. I will
search for such titles (LIKE '%px-%' should be sufficient).
Comment 3 Zigger 2005-07-09 03:45:28 UTC
*** Bug 2763 has been marked as a duplicate of this bug. ***
Comment 4 Zigger 2005-08-06 07:30:01 UTC
*** Bug 3055 has been marked as a duplicate of this bug. ***
Comment 5 Klaus Stock 2005-08-15 13:46:54 UTC
The problem should be solved by removing all old thumbnails alltogether (delete 
images/thumbs with everything below). Preferably during the update procedure.

As the file name generation procedure is still in flux, most existing 
thumbnails will be unfindable, so all they do is to take up space and make Tim 
Starling's life miserable.
Comment 6 Klaus Stock 2005-08-15 14:22:07 UTC
(In reply to comment #5)
> The problem should be solved by removing all old thumbnails alltogether 

Yeah, cool idea from me. Unless you do this yourself and find out that I forgot 
to mention that you'll need to expire all page caches! Otherwise, the caches 
pages will still try to access the (now gone) thumbnails. The thumbnails only 
get regenerated when the referring page is rendered from wikicode, NOT when it's 
just served from some cache!
Comment 7 Tim Starling 2005-09-05 09:15:53 UTC
The workaround is to just request the offending thumbnail of
[[Image:Something.jpg]], which will trigger migration of image into the new
directory structure, and thus out of the way. In the original example, that
means previewing a page containing [[Image:Something.jpg|123px]].
Comment 8 Zigger 2005-09-14 10:08:52 UTC
*** Bug 3457 has been marked as a duplicate of this bug. ***
Comment 9 Brion Vibber 2005-09-14 10:13:14 UTC
I'd recommend simply changing the thumbnail directory names; naming directories 
literally for the files feels rather too fragile, and as we see above does not lend 
itself to a smooth transition due to the name conflicts.

If we change the directory layout in a non-conflicting way and leave the existing 
files, things will naturally fill in without a requirement to pre-purge everything.
Comment 10 David Benbennick 2005-10-27 03:13:18 UTC
(In reply to comment #7)
> The workaround is to just request the offending thumbnail of
> [[Image:Something.jpg]], which will trigger migration of image into the new
> directory structure, and thus out of the way. In the original example, that
> means previewing a page containing [[Image:Something.jpg|123px]].

That doesn't seem to work.  See
http://commons.wikimedia.org/wiki/Image:Alpine_ibex.jpg.  If you have your
preferences set to display images at 800x600px, the page tries to display the
399x600px thumbnail, but fails with error 403 (Forbidden).
Comment 12 Brion Vibber 2006-01-22 04:23:18 UTC
Restored bug from flood attack.
Comment 13 Tim Starling 2006-02-02 12:47:30 UTC
This should be fixed in 1.5.7. The problem was buggy migration, not the need for
migration.
Comment 14 Brion Vibber 2006-02-02 17:47:47 UTC
*** Bug 3069 has been marked as a duplicate of this bug. ***
Comment 15 Wikipedia:en:User:Paddu 2006-02-04 23:05:25 UTC
Fixing the summary...
Comment 16 Wikipedia:en:User:Paddu 2006-02-04 23:07:03 UTC
Fixing the summary...
Comment 17 Wikipedia:en:User:Paddu 2006-02-04 23:11:28 UTC
*** Bug 4722 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links