Last modified: 2012-11-03 09:27:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27223, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 25223 - Allow data-URLs for icons added to the toolbar
Allow data-URLs for icons added to the toolbar
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-09-20 07:49 UTC by Michael M.
Modified: 2012-11-03 09:27 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Michael M. 2010-09-20 07:49:05 UTC 
Currently it's impossible to insert a button with a data-URL as icon into the toolbar. Could you change the autoIcon function such that the path isn't prepended to URLs starting with "data:"? Thanks.
Comment 1 Roan Kattouw 2010-09-22 14:59:41 UTC 
Keep in mind that data URLs are not universally supported: of the browsers supported by WikiEditor, they break in IE7.
Comment 2 Trevor Parscal 2010-09-22 17:17:52 UTC 
Right, you would need to support providing a data-URL+file-URL... Seems like it's possible to do, but strange.
Comment 3 Michael M. 2010-09-23 08:15:25 UTC 
(In reply to comment #1)
> Keep in mind that data URLs are not universally supported: of the browsers
> supported by WikiEditor, they break in IE7.

If data-URL were only used in personal user scripts this wouldn't be a problem. If a user uses IE7 and puts some code in his vector.js that inserts a toolbar button with a data-URL, it's his own fault.
Comment 4 Roan Kattouw 2010-09-23 14:53:24 UTC 
Well sure, but toolbar icons would more typically be added through site JS, and people like to copy others' user JS.
Comment 5 Bugmeister Bot 2011-08-19 19:12:54 UTC 
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links