Last modified: 2012-02-10 19:31:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26831, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24831 - Lqt loads page text multiple times
Lqt loads page text multiple times
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Low major (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
: 27076 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-17 19:50 UTC by Niklas Laxström
Modified: 2012-02-10 19:31 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Pass through TalkpageHeaderView wrapper on oldid (606 bytes, patch)
2011-01-10 07:07 UTC, Nikola Kovacs
Details

Description Niklas Laxström 2010-08-17 19:50:09 UTC
When viewing old version of page Support at translatewiki.net, Lqt loads the Support page text 51 times! When the page finally loads after 70 or seconds, exception is thrown: "Thread 6475 purports to be moved, but no redirect found in text {...}" Each content load takes at least 4 queries, possibly due to r44442.

See http://translatewiki.net/static/slow.txt for debug output.
Comment 1 Nikola Kovacs 2011-01-10 07:02:53 UTC
If this is what I think it is, I have a fix for that.
Comment 2 Nikola Kovacs 2011-01-10 07:07:22 UTC
Created attachment 7968 [details]
Pass through TalkpageHeaderView wrapper on oldid

With this patch, LQT will not attempt to show the threads on the page when you view an oldid of the header, similar to viewing a diff for the header. Otherwise LQT would show all the threads *currently* on the talk page, but each comment would contain the old revision of the header, causing the massive slowdown.
Comment 3 Nikola Kovacs 2011-02-25 08:06:19 UTC
*** Bug 27076 has been marked as a duplicate of this bug. ***
Comment 4 Helder 2011-04-13 00:47:15 UTC
Is this bug the same which causes the first comment to be repeated in all replies to the following thread?
http://pt.wikibooks.org/w/index.php?title=T%C3%B3pico:Wikilivros:Di%C3%A1logos_comunit%C3%A1rios/D%C3%BAvidas_quanto_a_barra_de_navega%C3%A7%C3%A3o&oldid=211729
Comment 5 p858snake 2011-04-30 00:09:47 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 6 Sumana Harihareswara 2011-11-14 16:29:23 UTC
Marking with the need-review keyword since this patch is awaiting review.  Thank you for the patch, Nikola.
Comment 7 Andrew Garrett 2012-02-10 19:31:09 UTC
Once again, spot on, Nikola! Thanks a lot.

Applied in r111187.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links