Last modified: 2010-08-24 09:19:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26824, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24824 - Excessive memory usage by new ImageMagick when scaling JPEGs
Excessive memory usage by new ImageMagick when scaling JPEGs
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal blocker (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
: 24834 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-17 06:47 UTC by Adam Cuerden
Modified: 2010-08-24 09:19 UTC (History)
17 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Adam Cuerden 2010-08-17 06:47:20 UTC
http://commons.wikimedia.org/wiki/File:Midsummer_Night%27s_Dream_Henry_Fuseli2.jpg

This won't thumbnail if you put your preferences to 1200px wide. It will thumbnail at lower resolutions than that.
Comment 1 OverlordQ 2010-08-17 06:57:32 UTC
I just checked my preferences page and thumbnail sizes only goes up to 300px. I have no clue where you're getting 1200 from.
Comment 2 Adam Cuerden 2010-08-17 10:25:58 UTC
(In reply to comment #1)
> I just checked my preferences page and thumbnail sizes only goes up to 300px. I
> have no clue where you're getting 1200 from.

Sorry, I wasn't entirely clear: 
The relevant preference is "Image Size Limit", which is what it's called on the Preference page. The file description page uses the thumbnailer to generate the image seen based on that preference, meaning that the maximum size the thumbnailer can handle needs to be over 1280x1024, the highest option available there.
Comment 3 Adam Cuerden 2010-08-17 10:33:21 UTC
At a rough guess, someone (fairly recently, since we have lots of working ones) set the thumbnailer to have a max size of one megapixel, forgetting it's used on file description pages too. 

1.5 or, if some extra leeway is desired, 2 megapixels should be ample to cover all cases.
Comment 4 Ryan Kaldari 2010-08-17 21:01:58 UTC
Perhaps it's a memory limit or a timeout. I can generate 3 megapixel thumbs for other images:
http://upload.wikimedia.org/wikipedia/commons/thumb/3/32/Polemonium_reptans_2009.jpg/2000px-Polemonium_reptans_2009.jpg
Comment 5 Bawolff (Brian Wolff) 2010-08-17 22:13:46 UTC
based on timing, perhaps related to Bug 19960 's fix.

As an interesting note, http://upload.wikimedia.org/wikipedia/commons/thumb/d/d7/Midsummer_Night%27s_Dream_Henry_Fuseli2.jpg/2528px-Midsummer_Night%27s_Dream_Henry_Fuseli2.jpg 2528px and higher seems work, and 2228px ( http://upload.wikimedia.org/wikipedia/commons/thumb/d/d7/Midsummer_Night%27s_Dream_Henry_Fuseli2.jpg/2228px-Midsummer_Night%27s_Dream_Henry_Fuseli2.jpg ) gives a different error message: 

"Error creating thumbnail: convert: Output file write error --- out of disk space? `/mnt/thumbs/wikipedia/commons/thumb/d/d7/Midsummer_Night's_Dream_Henry_Fuseli2.jpg/2228px-Midsummer_Night's_Dream_Henry_Fuseli2.jpg' @ error/jpeg.c/EmitMessage/235."

(compared to the 1200px one which gives no error).
Comment 6 Adam Cuerden 2010-08-18 02:47:39 UTC
Has the sharpening of JPEGs gotten turned off? New thumbnails look VERY soft, e.g. http://upload.wikimedia.org/wikipedia/commons/thumb/3/37/Benjamin_West_-_William_Woollett_-_The_Battle_at_La_Hogue.jpg/400px-Benjamin_West_-_William_Woollett_-_The_Battle_at_La_Hogue.jpg  which is nearly unusable.
Comment 7 p858snake 2010-08-18 03:03:25 UTC
(In reply to comment #6)
> Has the sharpening of JPEGs gotten turned off? New thumbnails look VERY soft,
> e.g.
> http://upload.wikimedia.org/wikipedia/commons/thumb/3/37/Benjamin_West_-_William_Woollett_-_The_Battle_at_La_Hogue.jpg/400px-Benjamin_West_-_William_Woollett_-_The_Battle_at_La_Hogue.jpg
>  which is nearly unusable.

That has no relation to this bug report, Please open a new one to address this, instead of just hopping between different bug reports.
Comment 8 Ryan Kaldari 2010-08-18 17:33:03 UTC
I've created a new bug for the sharpness issue, bug 24857.
Comment 9 User:Docu 2010-08-22 10:58:36 UTC
"thumbnails of large images have disappeared" (bug 24834) seems related
Comment 10 Alessandro Brollo 2010-08-22 12:36:17 UTC
Djvu file don't run too now.
Comment 11 Krzysztof Broszkowski 2010-08-22 22:14:24 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > I just checked my preferences page and thumbnail sizes only goes up to 300px. I

The same in my case above 300px the image disapears. "Nicene oxyrpapiry.jpg"
Comment 12 V85 2010-08-22 22:54:13 UTC
(In reply to comment #10)
> Djvu file don't run too now.

As Wikisource relies on displaying the separate pages of DjVu files for proofreading of texts, Wikisource would seem particularly affected by this error.
Comment 13 Tim Starling 2010-08-24 07:54:54 UTC
Fixed with live patch: using -resize before -thumbnail reduces memory usage by half.
Comment 14 Tim Starling 2010-08-24 08:57:13 UTC
Reverted that live patch and applied r71547 instead, which is even better at reducing memory usage for JPEGs. Adjusted summary so that I can dupe bug 24834 to this, since it appears to be identical.
Comment 15 Tim Starling 2010-08-24 08:58:37 UTC
*** Bug 24834 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links