Last modified: 2013-04-06 12:44:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24779 - Custom added tabs not collapse to menu on page resize
Custom added tabs not collapse to menu on page resize
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 44881
  Show dependency treegraph
 
Reported: 2010-08-13 11:33 UTC by Danny B.
Modified: 2013-04-06 12:44 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Danny B. 2010-08-13 11:33:18 UTC
If custom tab is added before watchlist tab, on page resize it's ignored and stays in, only original tabs scroll/collapse to the menu.
Comment 1 Roan Kattouw 2010-08-30 17:07:10 UTC
Did you add class="collapsible" to the custom tab?
Comment 2 Nihiltres 2011-02-16 21:27:57 UTC
Adding class="collapsible" to the custom tab doesn't seem to help. The problem seems to be something involving the $settings variable, but I don't understand the code well enough to analyze the problem further.
Comment 3 Derk-Jan Hartman 2011-02-16 21:32:14 UTC
TypeError: 'null' is not an object (evaluating '$settings.expandedContainer')

load.php:407
Comment 4 Bugmeister Bot 2011-08-19 19:12:54 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 5 Andre Klapper 2013-04-05 16:58:41 UTC
What are steps to reproduce this? How to add a custom tab?
Comment 6 Bartosz Dziewoński 2013-04-06 12:44:26 UTC
This certainly works now, even if it didn't work before.

Tested using this JS:

>>> mw.util.addPortletLink('p-views', '#', 'Test tab', 'ca-test', null, null, 'ca-history')
>>> $('#ca-test').addClass('collapsible')

The resulting tab collapses just like it should.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links